Use "scale" mode as default. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up more confusion between mode and direction. See also plone/plone.namedfile#102. Previously our definition of the `IImageScaleFactory` interface had the deprecated `direction="thumbnail"`. Other parts used `mode="contain"` by default, which does cropping, where in Plone we are used to simple scaling almost everywhere. Depending on your point of view, you could call this a bug fix (fixing the default to what Plone expects, to avoid surprises). Or you could call this a breaking change, because the default changes. It is beta stage, so I am okay with it either way.
This comment was marked as resolved.
This comment was marked as resolved.
|
The gh-actions pass. Now I test these two PRs together: They are not dependent on each other, but they change similar things, so it is good to test them in combination. |
jensens
approved these changes
Aug 13, 2022
MrTango
approved these changes
Sep 19, 2022
|
Testing these two again on Jenkins 6.0: |
|
That should be: Trying again. |
ale-rt
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up more confusion between mode and direction. See also plone/plone.namedfile#102.
Previously our definition of the
IImageScaleFactoryinterface had the deprecateddirection="thumbnail".Other parts used
mode="contain"by default, which does cropping, where in Plone we are used to simple scaling almost everywhere.Depending on your point of view, you could call this a bug fix (fixing the default to what Plone expects, to avoid surprises).
Or you could call this a breaking change, because the default changes.
It is beta stage, so I am okay with it either way.