Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
pbauer committed Sep 19, 2018
1 parent 28174f5 commit 4e008cb
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 16 deletions.
8 changes: 4 additions & 4 deletions plone/schemaeditor/tests/choice.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ If duplicate values are entered an error is raised.
... ['Alaska', 'Russia', 'United States', 'United States',
... 'Other'])
>>> browser.getControl('Save').click()
>>> print browser.contents
>>> print(browser.contents)
<...
<div class="error">The 'United States' vocabulary value conflicts with 'United States'.</div>
...
Expand Down Expand Up @@ -118,7 +118,7 @@ We can't set a vocabulary name AND values.
>>> browser.getLink(url='country').click()
>>> browser.getControl('values').value = "oups"
>>> browser.getControl('Save').click()
>>> print browser.contents
>>> print(browser.contents)
<...
<div class="error">You can not set a vocabulary name AND vocabulary values....
...
Expand Down Expand Up @@ -166,7 +166,7 @@ If duplicate values are entered an error is raised.
>>> ctl.value = '\n'.join(
... ['Lisp', 'Plone', 'Python', 'Lisp'])
>>> browser.getControl('Save').click()
>>> print browser.contents
>>> print(browser.contents)
<...
<div class="error">The 'Lisp' vocabulary value conflicts with 'Lisp'.</div>
...
Expand Down Expand Up @@ -210,7 +210,7 @@ Back to the edit form, vocabulary name is selected.

>>> browser.open(portal_url + '/@@schemaeditor')
>>> browser.getLink(url='categories').click()
>>> print browser.contents
>>> print(browser.contents)
<...
... selected>plone.schemaeditor.test.Categories</option...
...
20 changes: 10 additions & 10 deletions plone/schemaeditor/tests/editing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ error::
>>> browser.open(portal_url + '/@@schemaeditor')
Traceback (most recent call last):
...
Unauthorized: ...You are not authorized to access this resource...
zExceptions.unauthorized.Unauthorized: ...You are not authorized to access this resource...

We need to log in as a manager, because by default only managers get the 'Manage Schemata' permission::

Expand Down Expand Up @@ -62,11 +62,11 @@ normalized form of the title)::
>>> isinstance(IDummySchema['favorite_color'], TextLine)
True
>>> IDummySchema['favorite_color'].title
u'Favorite Color'
'Favorite Color'
>>> IDummySchema['favorite_color'].required
True
>>> IDummySchema['favorite_color'].description
u'Select your favorite color'
'Select your favorite color'


Editing a schema field attribute
Expand Down Expand Up @@ -98,7 +98,7 @@ of schema fields, which should reflect the change::
Let's confirm that the new default value was correctly saved to the actual schema::

>>> IDummySchema['favorite_color'].description
u'Enter your favorite color.'
'Enter your favorite color.'

If the schema is edited to have internationalized attributes::

Expand Down Expand Up @@ -130,11 +130,11 @@ value was set::
>>> type(IDummySchema['favorite_color'].description)
<... 'zope.i18nmessageid.message.Message'>
>>> IDummySchema['favorite_color'].description
u'favorite_color'
'favorite_color'
>>> IDummySchema['favorite_color'].description.domain
'plone'
>>> IDummySchema['favorite_color'].description.default
u'Enter your favorite color.'
'Enter your favorite color.'

Let's also check that the support for editing i18n Message values does not
persist its marker interface::
Expand Down Expand Up @@ -193,7 +193,7 @@ testbrowser doesn't support Javascript)::
[event: ContainerModifiedEvent on InterfaceClass]
[event: SchemaModifiedEvent on DummySchemaContext]
>>> browser.contents
''
b''

Now the field should be the third field of the schema::

Expand All @@ -220,7 +220,7 @@ They are moved to the end of the new fieldset::
[event: ContainerModifiedEvent on InterfaceClass]
[event: SchemaModifiedEvent on DummySchemaContext]
>>> browser.contents
''
b''

Now the field should be the seventh field of the schema::

Expand All @@ -236,7 +236,7 @@ They can be ordered into a fieldset::
[event: ContainerModifiedEvent on InterfaceClass]
[event: SchemaModifiedEvent on DummySchemaContext]
>>> browser.contents
''
b''
>>> get_field_fieldset(IDummySchema, 'favorite_color')
<Fieldset 'alpha'...of favorite_color, fieldA>

Expand Down Expand Up @@ -301,7 +301,7 @@ move it into an other fieldset and remove it::
[event: ContainerModifiedEvent on InterfaceClass]
[event: SchemaModifiedEvent on DummySchemaContext]
>>> browser.contents
''
b''
>>> browser.open('http://nohost/@@schemaeditor')
>>> browser.getLink(url='other_set/@@delete').click()
[event: ObjectRemovedEvent on TextLine]
Expand Down
2 changes: 1 addition & 1 deletion plone/schemaeditor/tests/extending.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,4 @@ We can save a color and confirm that it ends up in the schema's tagged values::
[event: SchemaModifiedEvent on DummySchemaContext]
>>> from plone.schemaeditor.tests.fixtures import IDummySchema
>>> IDummySchema.getTaggedValue('color')
{'field1': u'green'}
{'field1': 'green'}
14 changes: 13 additions & 1 deletion plone/schemaeditor/tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import doctest
import os
import plone.schemaeditor
import re
import six
import unittest


Expand All @@ -34,6 +36,15 @@ def tearDown(self):
classImplements(implementedBy(BaseRequest) - ITestLayer)


class Py23DocChecker(doctest.OutputChecker):
def check_output(self, want, got, optionflags):
if six.PY2:
got = re.sub('zExceptions.unauthorized.Unauthorized', 'Unauthorized', got)
got = re.sub("u'(.*?)'", "'\\1'", want)
want = re.sub("b'(.*?)'", "'\\1'", want)
return doctest.OutputChecker.check_output(self, want, got, optionflags)


def test_suite():
return unittest.TestSuite([

Expand All @@ -45,7 +56,8 @@ def test_suite():
'minmax.rst',
setUp=setUp,
tearDown=tearDown,
optionflags=optionflags
optionflags=optionflags,
checker=Py23DocChecker(),
),

])
Expand Down

0 comments on commit 4e008cb

Please sign in to comment.