Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parent lookup, test setup #49

Merged
merged 2 commits into from
Feb 1, 2017
Merged

fix parent lookup, test setup #49

merged 2 commits into from
Feb 1, 2017

Conversation

davisagli
Copy link
Member

No description provided.

@davisagli davisagli merged commit 4add166 into master Feb 1, 2017
@davisagli davisagli deleted the plonezope4 branch February 1, 2017 18:17
xmlns:zcml="http://namespaces.zope.org/zcml">

<!-- only load PageTemplates zcml in Zope 4 -->
<configure zcml:condition="installed Products.PageTemplates.engine">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although tests did pass, shouldn't that be Products.PageTemplates rather than Products.PageTemplates.engine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No -- earlier versions of Zope also have zcml in Products.PageTemplates, but loading it here fails because it uses directives that aren't registered in this test setup. On Zope 4, which has the engine module in Products.PageTemplates, the zcml is simpler and works (and is necessary to render using Chameleon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants