Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dx siteroot #27
Dx siteroot #27
Changes from 11 commits
87d66da
5e11052
4a7e3d3
c922676
8716319
1b1e8ce
feab801
5ef3cf5
5dd659a
9472f87
3042a85
6b9b95b
1c397bc
e46da91
d99d51d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a breakpoint here, and it did not get triggered on startup and also not when running the (non-robot) tests from CMFPlone. So there is a chance that this is no longer needed.
But it seems fine for me to keep this, so we avoid weird errors in corner cases in tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this branch is needed to fix the plip branch build.
After I added this commit:
I had a succesful build:
Before I started:
which is not yet over but I expect it to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my mistake to remove this checkout from the PLIP.
I probably got confused between the various packages. Sorry!
Since the job of this individual PR is green on 6.0, and I already let 5.2 use a maintenance branch, it would be fine to merge this PR now, without the other PLIP PRs.
@ale-rt Do you want to push the merge button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauritsvanrees I see no harm in doing that, but waiting for other people review seems a good idea: CC @plone/framework-team