Skip to content

Commit

Permalink
Disable flake8-pytest and flake8-todo.
Browse files Browse the repository at this point in the history 
It's strange.  Without this, when I run flake8 I get this:
$ .tox/lint-py27/bin/flake8 --doctests src tests setup.py
src/plone/testing/layer.py:127:13: W503 line break before binary operator
src/plone/testing/layer.py:128:13: W503 line break before binary operator
setup.py:51:9: W503 line break before binary operator

We should ignore W503, so I pass an extra option, and then I get different errors:
$ .tox/lint-py27/bin/flake8 --doctests --ignore=W503 src tests setup.py
src/plone/testing/zope.py:124:19: T000 Todo note found.
src/plone/testing/tests.py:95:9: T003 use of Django-style assert statement found (instead of regular assert): assertIsNotNone
  • Loading branch information
@mauritsvanrees
mauritsvanrees committed Mar 1, 2019
1 parent cc3fe1a commit 6f92e57
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tox.ini
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ deps =
flake8-debugger
flake8-deprecated
flake8-print
flake8-pytest
flake8-todo
# flake8-pytest
# flake8-todo
flake8-isort
mccabe
# Potential flake8 plugins that should be used: # TBD
Expand Down

1 comment on commit 6f92e57

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.testing/150/violations

src/plone/testing/layer.py:127:13: W503 line break before binary operator
src/plone/testing/layer.py:128:13: W503 line break before binary operator

Follow these instructions to reproduce it locally.

Please sign in to comment.