Skip to content

Commit

Permalink
Merge pull request #54 from plone/roto-pin-zodb
Browse files Browse the repository at this point in the history
Pin ZODB to < 5.4.0 for now
  • Loading branch information
pbauer authored Oct 2, 2018
2 parents 5e6c6dd + 64b5c84 commit bfc4be8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ New features:

Bug fixes:

- Pinned ZODB to < 5.4.0 for testing to avoid flaky doctest layer teardowns.
[Rotonen]

- Loosened doctest assertions to keep up with Zope-side changes.
[Rotonen]

Expand Down
3 changes: 3 additions & 0 deletions buildout.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ prefer-final = false
setuptools =
zc.buildout =
plone.testing =
# From 2018-10-02
# Please remove this pinning after we get on top of the ZODB issues!
ZODB = < 5.4.0

[test]
recipe = collective.xmltestreport
Expand Down

1 comment on commit bfc4be8

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.testing/106/violations

src/plone/testing/z2.py:98:1: C901 'uninstallProduct' is too complex (15)
src/plone/testing/z2.py:138:19: T000 Todo note found.
src/plone/testing/z2.py:414:5: C901 'Startup.setUpPatches' is too complex (11)
src/plone/testing/z2.py:829:11: T000 Todo note found.

Follow these instructions to reproduce it locally.

Please sign in to comment.