-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix injection of ZopeLite test configuration into the global Zope configuration. #65
Conversation
@thet thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…figuration. Fixese #64
@jenkins-plone-org please run jobs |
@thet Merging this broke all of our jenkins tests like this:
You can easily reproduce it locally like this: I don't really know what the warning is good for. We have not had random errors since we fixed all test-isolation-issues. |
🙈 |
# NOTE: Keep that import here. | ||
# Having it on module-level has the side effect of injecting the | ||
# ZopeLite test configuration into the global Zope configuration. | ||
from Testing.ZopeTestCase.ZopeLite import _patched as ZOPETESTCASEALERT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this and the following lines all together?
Looking at it, I can't make sense of importing something and then throwing an error if the import was successful.
@datakurre @pbauer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It seems that running ZopeTestCase
together with ours had side-effects that needed to be warned about. See 3268cda
I should hope that these issues are gone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, that makes sense.
I remeber also, that was done at the Alpine City Sprint.
Fixese #64