-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC New Feature: Annotate Versions Used #25
Comments
We already have I wonder if a simple comment above the version pin in |
The idea of
I had also the idea to use comments. Unfortunately Pythons |
I added an experimental implementation. The source of the annotations is for now the section I proposed above. It would feel better if version pin and annotation would be closer together. |
Probably ConfigObj solves the keep-comment problem https://pypi.python.org/pypi/configobj |
ConfigObj is not compatible with our buildout configparser format. So I for now implemented this as proposed using a |
We use a bunch of versions we can not update for several reasons.
Example: We use z3c.forms 2.3.9, but there is a bugfix release 2.3.10 out and a major release 3.3.0. We can not use the bugfix release, because it breaks tests and probably other code. Also 3.3.0 has more compatibility problems. So I'd like to stick general comment to z3c.form. This can be just text or text with a link to an issue.
I'd like to have a list of this reasons in a machine readable format in order to be read by plone.versionscheck and added to the report. Thus the input has to be plain text, so it can be displayed on command-line or added to the html report.
I do not want to introduce per-version comments, because I fear this gets difficult to keep in sync with newer releases and it is significant more work to keep the information up to date. Also this variant is simple to implement.
This can be used by buildout.coredev and also by customer projects. It helps with later updates.
I propose a simple format using the existing buildout infrastructure. A new section
[versionannotations]
is expected by default (may be overridden by ``versionannotations = othersectionname` in [buildout] section). The extension part of plone.versioncheck reads this section and add all annotations found there to its json output file. A single annotation can be one or more lines. likeOn command line the output is appended at the end of the version information like so::
Did I miss something? Other ideas?
The text was updated successfully, but these errors were encountered: