-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for parent summary serializer when the parent has a but it's empty #148
Conversation
@sneridagh thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
@davisagli ready |
I tried it in a project with content (Document) having
preview_image_link
behavior, and it broke when creating childs because the parent has the empty field, and it tried to accessto_object
on it.https://github.com/kitconcept/kitconcept.com/actions/runs/8846612966/job/24369069918?pr=145#step:7:912
Problem: this is in 6.0.11 :(
Also, changed the order of the condition in the
image_field
index. Since the most probably is that you change from the default, existing,preview_image
to thepreview_image_link
, is more sane to check the latter first, then the default.