Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scrollbars only if needed #205

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Show scrollbars only if needed #205

merged 4 commits into from
Jul 6, 2020

Conversation

vincentfretin
Copy link
Member

This fixes #154

@mister-roboto
Copy link

@vincentfretin thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@vincentfretin
Copy link
Member Author

I fixed the rule controlpanels.plone.less and edited by hand barceloneta-compiled.css
I searched for instructions how to rebuild it but couldn't find them.
Do I need some upgrade step? I don't see my change in Plone.

@vincentfretin
Copy link
Member Author

vincentfretin commented Jul 6, 2020

I probably didn't run the buildout after checkout plone.barceloneta it's ok now I see the change.

@vincentfretin
Copy link
Member Author

vincentfretin commented Jul 6, 2020

I found out myself the commands to rebuild barceloneta-compiled.css and barceloneta-compiled.css.map, I added them in the README. If you made changes to the less files, to rebuild the files barceloneta-compiled.css and barceloneta-compiled.css.map you can execute this:

cd plonetheme.barceloneta/plonetheme/barceloneta/theme/less
npx lessc --source-map=barceloneta-compiled.css.map barceloneta.plone.local.less barceloneta-compiled.css

@vincentfretin
Copy link
Member Author

I verified the sourcemap through chrome inspector, it works great and show the less files. It's even better than the previous sourcemap where the urls weren't correct.

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants