tsconfig centralization + Update RAC everywhere (#6536)

plone · Dec 13, 2024 · 086f950 · 086f950
1 parent 4dff6bd
commit 086f950
Show file tree

Hide file tree

Showing 27 changed files with 58 additions and 1,850 deletions.
diff --git a/apps/nextjs/package.json b/apps/nextjs/package.json
@@ -18,7 +18,7 @@
     "@tanstack/react-query": "^5.59.0",
     "next": "14.2.14",
     "react": "^18",
-    "react-aria-components": "^1.4.0",
+    "react-aria-components": "^1.5.0",
     "react-dom": "^18"
   },
   "devDependencies": {

diff --git a/apps/vite-ssr/package.json b/apps/vite-ssr/package.json
@@ -24,7 +24,7 @@
     "axios": "^1.6.5",
     "get-port": "^7.0.0",
     "react": "^18.2.0",
-    "react-aria-components": "^1.4.0",
+    "react-aria-components": "^1.5.0",
     "react-dom": "^18.2.0",
     "sirv": "^2.0.4"
   },

diff --git a/apps/vite/package.json b/apps/vite/package.json
@@ -19,7 +19,7 @@
     "@tanstack/router-devtools": "^1.67.0",
     "axios": "^1.6.5",
     "react": "^18.2.0",
-    "react-aria-components": "^1.4.0",
+    "react-aria-components": "^1.5.0",
     "react-dom": "^18.2.0"
   },
   "devDependencies": {

diff --git a/packages/blocks/Image/index.tsx b/packages/blocks/Image/index.tsx
@@ -1,4 +1,4 @@
-import { BlockViewProps } from '@plone/types';
+import type { BlockViewProps } from '@plone/types';
 import { usePloneProvider } from '@plone/providers';
 
 const ImageBlockView = (props: BlockViewProps) => {

diff --git a/packages/blocks/RenderBlocks/BlockWrapper.tsx b/packages/blocks/RenderBlocks/BlockWrapper.tsx
@@ -1,4 +1,4 @@
-import { ReactNode } from 'react';
+import type { ReactNode } from 'react';
 import cx from 'clsx';
 import type { RenderBlocksProps } from './RenderBlocks';
 

diff --git a/packages/blocks/Teaser/index.tsx b/packages/blocks/Teaser/index.tsx
@@ -1,4 +1,4 @@
-import { BlockViewProps } from '@plone/types';
+import type { BlockViewProps } from '@plone/types';
 import { Link } from '@plone/components';
 
 const TeaserBlockView = (props: BlockViewProps) => {

diff --git a/packages/blocks/index.ts b/packages/blocks/index.ts
@@ -1,4 +1,4 @@
-import { ConfigType } from '@plone/registry';
+import type { ConfigType } from '@plone/registry';
 import { slate } from './config/slate';
 import { blocksConfig } from './config';
 

diff --git a/packages/blocks/news/6536.internal b/packages/blocks/news/6536.internal
@@ -0,0 +1 @@
+Centralize `tsconfig`. @sneridagh
diff --git a/packages/blocks/package.json b/packages/blocks/package.json
@@ -28,9 +28,11 @@
   "publishConfig": {
     "access": "public"
   },
+  "type": "module",
   "main": "index.ts",
   "scripts": {
     "test": "vitest",
+    "check-ts": "tsc --project tsconfig.json",
     "dry-release": "release-it --dry-run",
     "release": "release-it",
     "release-major-alpha": "release-it major --preRelease=alpha",

diff --git a/packages/helpers/news/6536.internal b/packages/helpers/news/6536.internal
@@ -0,0 +1 @@
+Centralize `tsconfig`. @sneridagh
diff --git a/packages/helpers/tsconfig.json b/packages/helpers/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "extends": "tsconfig/react-library.json",
-  "include": ["src", "src/**/*.js"],
+  "include": ["src"],
   "exclude": [
     "node_modules",
     "build",

diff --git a/packages/providers/news/6536.internal b/packages/providers/news/6536.internal
@@ -0,0 +1 @@
+Centralize `tsconfig`. @sneridagh
diff --git a/packages/providers/tsconfig.json b/packages/providers/tsconfig.json
@@ -1,26 +1,5 @@
 {
-  "compilerOptions": {
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "target": "es2022",
-    "allowJs": true,
-    "resolveJsonModule": true,
-    "moduleDetection": "force",
-    "isolatedModules": true,
-    "verbatimModuleSyntax": true,
-
-    "strict": true,
-    "noImplicitOverride": true,
-
-    "lib": ["es2022", "dom", "dom.iterable"],
-    "module": "preserve",
-    "noEmit": true,
-
-    "jsx": "react-jsx",
-
-    "allowSyntheticDefaultImports": true,
-    "forceConsistentCasingInFileNames": true
-  },
+  "extends": "tsconfig/react-library.json",
   "include": ["src"],
   "exclude": [
     "node_modules",

diff --git a/packages/slots/components/ContentArea.tsx b/packages/slots/components/ContentArea.tsx
@@ -1,5 +1,5 @@
 import RenderBlocks from '@plone/blocks/RenderBlocks/RenderBlocks';
-import { SlotComponentProps } from '../SlotRenderer';
+import type { SlotComponentProps } from '../SlotRenderer';
 import config from '@plone/registry';
 
 const ContentArea = (props: SlotComponentProps) => {

diff --git a/packages/slots/components/Logo.stories.tsx b/packages/slots/components/Logo.stories.tsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import Logo from './Logo';
 
 import type { Meta, StoryObj } from '@storybook/react';

diff --git a/packages/slots/components/Logo.tsx b/packages/slots/components/Logo.tsx
@@ -1,4 +1,4 @@
-import { SlotComponentProps } from '../SlotRenderer';
+import type { SlotComponentProps } from '../SlotRenderer';
 import { Link } from '@plone/components';
 import LogoImage from './Logo.svg';
 import config from '@plone/registry';

diff --git a/packages/slots/components/MainFooter.tsx b/packages/slots/components/MainFooter.tsx
@@ -1,4 +1,4 @@
-import { SlotComponentProps } from '../SlotRenderer';
+import type { SlotComponentProps } from '../SlotRenderer';
 import { Container, Link } from '@plone/components';
 import Logo from './Logo';
 

diff --git a/packages/slots/components/Navigation.stories.tsx b/packages/slots/components/Navigation.stories.tsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import Navigation from './Navigation';
 
 import type { Meta, StoryObj } from '@storybook/react';

diff --git a/packages/slots/news/6536.internal b/packages/slots/news/6536.internal
@@ -0,0 +1 @@
+Centralize `tsconfig`. @sneridagh
diff --git a/packages/slots/package.json b/packages/slots/package.json
@@ -28,9 +28,11 @@
   "publishConfig": {
     "access": "public"
   },
+  "type": "module",
   "main": "index.ts",
   "scripts": {
     "test": "vitest",
+    "check-ts": "tsc --project tsconfig.json",
     "dry-release": "release-it --dry-run",
     "release": "release-it",
     "release-major-alpha": "release-it major --preRelease=alpha",
@@ -52,7 +54,7 @@
     "@plone/client": "workspace:*",
     "@plone/components": "workspace:*",
     "@plone/registry": "workspace:*",
-    "react-aria-components": "^1.4.0"
+    "react-aria-components": "^1.5.0"
   },
   "devDependencies": {
     "@plone/types": "workspace:*",

diff --git a/packages/theming/news/6536.internal b/packages/theming/news/6536.internal
@@ -0,0 +1 @@
+Centralize `tsconfig`. @sneridagh
diff --git a/packages/theming/tsconfig.json b/packages/theming/tsconfig.json
@@ -1,36 +1,4 @@
 {
-  "compilerOptions": {
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "target": "es2022",
-    "allowJs": true,
-    "resolveJsonModule": true,
-    "moduleDetection": "force",
-    "isolatedModules": true,
-    "verbatimModuleSyntax": true,
-
-    "strict": true,
-    "noImplicitOverride": true,
-
-    "lib": ["es2022", "dom", "dom.iterable"],
-    "module": "preserve",
-    "noEmit": true,
-
-    "jsx": "react-jsx",
-
-    "allowSyntheticDefaultImports": true,
-    "forceConsistentCasingInFileNames": true,
-
-    "paths": {}
-  },
-  "include": ["src/index.ts"],
-  "exclude": [
-    "node_modules",
-    "build",
-    "public",
-    "coverage",
-    "src/**/*.test.{js,jsx,ts,tsx}",
-    "src/**/*.spec.{js,jsx,ts,tsx}",
-    "src/**/*.stories.{js,jsx,ts,tsx}"
-  ]
+  "extends": "tsconfig/react-library.json",
+  "include": ["index.ts"]
 }
diff --git a/packages/tsconfig/base.json b/packages/tsconfig/base.json
@@ -2,22 +2,27 @@
   "$schema": "https://json.schemastore.org/tsconfig",
   "display": "Default",
   "compilerOptions": {
-    "target": "ESNext",
-    "lib": ["DOM", "DOM.Iterable", "ESNext"],
-    "module": "commonjs",
-    "allowJs": true,
-    "skipLibCheck": true,
     "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
-    "forceConsistentCasingInFileNames": true,
-    "strictPropertyInitialization": false,
-    "moduleResolution": "Node",
+    "skipLibCheck": true,
+    "target": "es2022",
+    "allowJs": true,
     "resolveJsonModule": true,
+    "moduleDetection": "force",
     "isolatedModules": true,
+    "verbatimModuleSyntax": true,
+
+    "strict": true,
+    "noImplicitOverride": true,
+
+    "lib": ["es2022", "dom", "dom.iterable"],
+    "module": "preserve",
     "noEmit": true,
-    "noImplicitAny": false,
-    "strict": false
+
+    "allowSyntheticDefaultImports": true,
+    "forceConsistentCasingInFileNames": true,
+
+    "paths": {}
   },
   "include": ["src"],
-  "exclude": ["node_modules"]
+  "exclude": ["node_modules", "build", "public", "coverage"]
 }
diff --git a/packages/tsconfig/baseAdobe.json b/packages/tsconfig/baseAdobe.json
diff --git a/packages/tsconfig/baseold.json b/packages/tsconfig/baseold.json
diff --git a/packages/tsconfig/nextjs.json b/packages/tsconfig/nextjs.json