Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Steve Piercy <web@stevepiercy.com>
  • Loading branch information
sneridagh and stevepiercy authored Dec 14, 2023
1 parent a7242c1 commit 370a3c2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion docs/source/upgrade-guide/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ Thus it is safe to run it on top of your project and answer the prompts.

### ESlint project configuration update

Since `@plone/registry` and other Volto dependencies packages are now released as standalone, it is needed to update some configurations files from your projects. In `.eslintrc.js`:
`@plone/registry` and [other packages on which Volto depends](https://github.com/plone/volto/tree/main/packages) are now stand-alone releases in the monorepo structure released in 18.0.0-alpha.4.

You must update the configuration file {file}`.eslintrc.js` in your projects, according to the following `git diff` patch.

```diff
@@ -18,9 +19,6 @@ if (configFile) {
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-volto/news/5530.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fixed generator ESlint config. Added tests and docs. @sneridagh
Fixed the project generator's ESLint configuration, added code quality checks to the CI to ensure a generated project can run these checks, and added documentation for how to reconfigure ESLint in projects. @sneridagh
2 changes: 1 addition & 1 deletion packages/volto/news/5530.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Do not pin the `eslint-plugin-jsx-a11y` version in Volto. Fixed generator ESlint config. Added tests and docs. @sneridagh
Fixed the project generator's ESLint configuration, added code quality checks to the CI to ensure a generated project can run these checks, and added documentation for how to reconfigure ESLint in projects. @sneridagh

0 comments on commit 370a3c2

Please sign in to comment.