A querystring appearing in the URL after accessing a page with a listing/search block

[sneridagh]

After merging #4159, the site URL start to have a strange behavior, if a listing block is present, then the URL shows a querystring:

The interesting thing is that it appears everywhere once you click in another router link.

In the videos in #4159 it does not show, maybe something that was introduced lately in the PR?

/cc @bipoza @erral @ionlizarazu this is quite urgent, we would need to fix asap. If it's not possible, I'd better revert the change and proceed with another release.

[sneridagh]

Also, I can see that the @querystring endpoint is being hit multiple times... this is another thing that we have to make sure that doesn't happen.

[erral]

We will look at it

[wesleybl]

Also, I can see that the @querystring endpoint is being hit multiple times... this is another thing that we have to make sure that doesn't happen.

Maybe that's not just in this PR. See:

#4124

[sneridagh]

@erral Thanks a lot! Let's see if we can push a fix asap! If not, let me know and we can revert and postpone it until we have a better one. Please keep me posted!

[erral]

It looks like the code under the useEffect in usePagination is run no matter the user has gone away from the page where the pagination is shown.

Somehow this useEffect should be deactivated (sorry if the concept is not correct) when browsing away.

[sneridagh]

@erral we just merged some fixes to the listing/search blocks in cases of two of them are present in the same page, see:

#4694

Maybe now the situation is improved.

It's what I saw, the usePagination hook should be addressed.

[erral]

I managed to remove the querystring before this merge, so I will test it again.

Anyway I have seen something strange going on, because I removed the querystring when going to any page except the home page. I need to test my fix further.