Fix search block in edit mode re-queries multiple blocks with an empty search text

[reebalazs]

Multiple issues fixed:

Fix search block search text re-query

SearchBlockEdit calls onTriggerSearch without parameters. But
onTriggerSearch does not ignore toSearchText in case it's not specified
in the call.

If there are multiple blocks in the page, this causes the search text
of all the other block's reset and re-queried with the wrong condition.

Performance optimize onTriggerSearch

Previous to this fix, onTriggerSearch triggered 28 times during loading
and edit page with two search blocks in it. After the fix, it's just 2
times.

The fix is that the deep comparison condition for the query also has to
be applied in withSearch.jsx. Without that, the deep comparison in
SearchBlockEdit.jsx has no effect. This is because the onTriggerSearch
function will be regenerated each time there is an identity change in
data.query anyway. So the hook guard in SearchBlockEdit will be
triggered anyway because onTriggerSearch has changed.

In addition, I personally find it better to use JSON.stringify for the
deep comparison and skip using the useDeepCompareEffect hook. This uses
dequal under the hood which is capable to compare a lot of other data
types, but with pure json data it has no advantage to a string
comparison with JSON.stringify. (That said it would also work with
useDeepCompareEffect but perhaps a bit slower.)

Remove SearchableText from the query only if there is a searchtext

Previously, the SearchableText was removed within normalizeState, even
if there was no searchText. This is wrong, the searchText should only
replace SearchableText condition if searchText is provided.

In the edit page this caused the following, in case a SearchableText
is specified as a condition to the block:

• Upon loading the edit page
• First the search blocks were loaded with correct results
• Then a second set of query was issued, but with the SearchableText
  condition stripped out. This means that the query result was wrong.

The current fix fixes the double querying, and the faulty condition in
the second query that results in faulty results.

The current fix still does not address the fact that eventually the
searchText should be a distinct facet from SearchableText, and the two
conditions could be combined, in comparison to the current state, when
one overrides the other.

[netlify]

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	8d94359
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/643927b41ee78d00081cf63a

[cypress]

Passing run #4935 ↗︎

0

489

20

0

0

Details:

Add changelog
Project: Volto	Commit: 8d94359923
Status: Passed	Duration: 12:41 💡
Started: Apr 14, 2023 10:18 AM	Ended: Apr 14, 2023 10:31 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[reebalazs]

Fixes #4697