Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix training links #4635

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Fix training links #4635

merged 5 commits into from
Apr 13, 2023

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Apr 2, 2023

Do not merge until the URL https://2022.training.plone.org/ is live.

Although I marked it as "draft", it is ready for review. I just don't want someone to get shiny green button happy. 🤪 👇

Refs:

Do not merge until the new URL 2022.training.plone.org is live.
@netlify
Copy link

netlify bot commented Apr 2, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 4186e08
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6437a8f9f22f3900077a2924
😎 Deploy Preview https://deploy-preview-4635--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stevepiercy stevepiercy marked this pull request as draft April 2, 2023 05:14
@stevepiercy stevepiercy self-assigned this Apr 2, 2023
@cypress
Copy link

cypress bot commented Apr 2, 2023

Passing run #4910 ↗︎

0 489 20 0 Flakiness 0

Details:

Fix grammar and syntax
Project: Volto Commit: 4186e0883e
Status: Passed Duration: 14:00 💡
Started: Apr 13, 2023 7:05 AM Ended: Apr 13, 2023 7:19 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stevepiercy stevepiercy marked this pull request as ready for review April 13, 2023 06:54
@stevepiercy stevepiercy removed the request for review from tiberiuichim April 13, 2023 07:03
@stevepiercy
Copy link
Collaborator Author

stevepiercy commented Apr 13, 2023

Ready for review! @ksuess @sneridagh @fredvd @nileshgulia1

Upon merge, please close plone/training#740 as this is the final PR to update Training links.

Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevepiercy stevepiercy merged commit c18898d into master Apr 13, 2023
@stevepiercy stevepiercy deleted the fix-training-links branch April 13, 2023 10:13
sneridagh added a commit that referenced this pull request Apr 17, 2023
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants