Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Developer Guidelines to Contributing #4665

Closed
stevepiercy opened this issue Apr 9, 2023 · 0 comments · Fixed by #4666
Closed

Rename Developer Guidelines to Contributing #4665

stevepiercy opened this issue Apr 9, 2023 · 0 comments · Fixed by #4666
Assignees
Milestone

Comments

@stevepiercy
Copy link
Collaborator

"Contributing" is a universally accepted term as where one should first look when they want to contribute to a project. Currently the Volto contributing docs are buried under Frontend > Developer Guidelines > Contributing. Additionally "guidelines" is an optional term, whereas this part of the Volto documentation discusses required things, including tests, code quality, and documentation.

I therefore suggest the following shuffling around of content.

  • Merge content from /developer-guidelines/contributing.md into /developer-guidelines/index.md.
  • Delete /developer-guidelines/contributing.md.
  • Rename /developer-guidelines/ to /contributing/.

Supersedes #3574.

PR incoming.

@stevepiercy stevepiercy added this to the Plone 6.0 milestone Apr 9, 2023
@stevepiercy stevepiercy self-assigned this Apr 9, 2023
@stevepiercy stevepiercy moved this from New to In Progress in Release Plone 6 docs Apr 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Release Plone 6 docs Apr 9, 2023
sneridagh added a commit that referenced this issue Apr 10, 2023
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
sneridagh added a commit that referenced this issue Apr 11, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit that referenced this issue Apr 17, 2023
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant