Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RelationList field with StaticCatalogVocabulary and SelectWidget. #4614

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Mar 25, 2023

Please test with plone/plone.restapi#1605


See example.contenttype https://github.com/collective/example.contenttype for example content type with relation fields for testing purpose.

image


See also #3355

@netlify
Copy link

netlify bot commented Mar 25, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit f4f3425
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6421389c3f9fea00076b8a76
😎 Deploy Preview https://deploy-preview-4614--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ksuess
Copy link
Member Author

ksuess commented Mar 25, 2023

@cypress
Copy link

cypress bot commented Mar 25, 2023

Passing run #4709 ↗︎

0 489 20 0 Flakiness 0

Details:

Apply suggestions from code review
Project: Volto Commit: f4f34254ba
Status: Passed Duration: 11:44 💡
Started: Mar 27, 2023 6:36 AM Ended: Mar 27, 2023 6:48 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ksuess
Copy link
Member Author

ksuess commented Mar 25, 2023

Please test with plone/plone.restapi#1605

@ksuess ksuess marked this pull request as ready for review March 25, 2023 16:36
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few enhancements, grammar and spelling fixes, and suggestions.

I am not sure if I got the introductory descriptions of each relation field exactly correct. Feel free to revise them to be more accurate.

docs/source/recipes/widget.md Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Show resolved Hide resolved
docs/source/recipes/widget.md Show resolved Hide resolved
ksuess and others added 2 commits March 27, 2023 07:40
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice revision. This is much clearer. Minor spelling and grammar fixes, and the docs are good to go. Thank you!

docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approved. Code should be reviewed by a core maintainer.

Copy link
Contributor

@tiberiuichim tiberiuichim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @ksuess !

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work @ksuess !!! Very much needed!

I'll merge as soon we have a release in p.restapi. I'll push for it.

@sneridagh sneridagh merged commit cafad1c into master Apr 11, 2023
@sneridagh sneridagh deleted the StaticCatalogVocabulary branch April 11, 2023 15:26
sneridagh pushed a commit that referenced this pull request Apr 11, 2023
…get. (#4614)

Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit that referenced this pull request Apr 17, 2023
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
@sneridagh sneridagh mentioned this pull request Sep 26, 2023
ksuess added a commit to plone/documentation that referenced this pull request Oct 24, 2023
ksuess added a commit to plone/documentation that referenced this pull request Oct 25, 2023
* Fix pattern_options. Should be dictionary.
* Remove TODO StaticCatalogVocabulary in Volto
  Implemented with plone/volto#4614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants