Add UID to relationvalue_converter summary #1605
Conversation
Support RelationList field with named StaticCatalogVocabulary and SelectWidget
|
@ksuess thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi canceled.
|
|
@jenkins-plone-org please run jobs |
|
@tisto could you please take a look and have a release? plone/volto#4614 depends on this one. |
|
@sneridagh will do. Need to fix the Python 3.6 thingy in master first. |
|
@jenkins-plone-org please run jobs |
| @@ -0,0 +1 @@ | |||
| Add UID to relationvalue_converter summary. @ksuess | |||
There was a problem hiding this comment.
@ksuess we use [ksuess] in backend packages. :) Just FYI. I will fix this for you.
There was a problem hiding this comment.
@tisto We just decided to switch to using @githubusername everywhere, for consistency. plone/documentation#1478 (comment)
There was a problem hiding this comment.
As a bonus, GitHub renders @username format to a clickable username.
There was a problem hiding this comment.
@davisagli ok, that's new for me. Awesome! That makes lots of sense to me. Will stick to this from now on for plone.rest(api) releases.
There was a problem hiding this comment.
@ksuess sorry, for the noise. Turns out you were right and I was wrong. :)
Support RelationList field with named StaticCatalogVocabulary and SelectWidget