Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URL a literal string to fix broken link #4667

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

stevepiercy
Copy link
Collaborator

This is the third time I have fixed this link to ReactJS.org. I don't have any clue why it does not stay fixed.

@netlify
Copy link

netlify bot commented Apr 9, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 18387e1
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64329f413ef87b0008287138

@cypress
Copy link

cypress bot commented Apr 9, 2023

Passing run #4854 ↗︎

0 489 20 0 Flakiness 0

Details:

add news item
Project: Volto Commit: 18387e1d21
Status: Passed Duration: 15:06 💡
Started: Apr 9, 2023 11:22 AM Ended: Apr 9, 2023 11:37 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stevepiercy
Copy link
Collaborator Author

Side note: I don't know if it is appropriate to have the same news item listed twice. Should I remove the most recent one from the 17.0.0-alpha.3 or leave both?

@davisagli
Copy link
Member

@stevepiercy I don't think we should edit release notes from a version that was already released. It's not a big deal; I wouldn't put effort into solving that problem.

@stevepiercy
Copy link
Collaborator Author

In general, I agree with not editing release notes, but I think there are valid exceptions to the general rule, including:

  • Error or omission.
  • Links become invalid and need to be updated or removed.

@davisagli
Copy link
Member

@stevepiercy ok, that makes sense.

@stevepiercy
Copy link
Collaborator Author

I also noticed there are a lot of duplicate news items between the 16 and 17-alpha releases. I don't know if that is intentional or a bug with towncrier. @mauritsvanrees @sneridagh what are your thoughts?

I'm going ahead with merging this PR for now, because without it, GitHub Actions on plone/documentation fail.

@stevepiercy stevepiercy merged commit c09c578 into master Apr 9, 2023
@stevepiercy stevepiercy deleted the fix-linkcheck-20230409 branch April 9, 2023 22:48
@davisagli
Copy link
Member

@stevepiercy It's an accurate record of what's happening. We're making changes for 17, backporting them to the 16.x branch, and then copying the release notes for 16.x releases back to the master branch after a release. When we port a change to another branch, there are multiple releases where the change is new and warrants being noted.

sneridagh added a commit that referenced this pull request Apr 10, 2023
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
sneridagh added a commit that referenced this pull request Apr 11, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit that referenced this pull request Apr 17, 2023
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants