Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sitemap.xml.gz is not compressed. Not gzip format #4622

Closed
avoinea opened this issue Mar 29, 2023 · 3 comments
Closed

sitemap.xml.gz is not compressed. Not gzip format #4622

avoinea opened this issue Mar 29, 2023 · 3 comments
Assignees
@dobri1408
Labels
01 type: bug

Comments

@avoinea
Copy link
Member

avoinea commented Mar 29, 2023

Download https://demo.plone.org/sitemap.xml.gz

$ gzip -d sitemap.xml.gz 
gzip: sitemap.xml.gz: not in gzip format

$ gunzip sitemap.xml.gz 
gzip: sitemap.xml.gz: not in gzip format

$ file sitemap.xml.gz 
sitemap.xml.gz: XML 1.0 document, ASCII text
@avoinea avoinea changed the title sitemap.xml.gz not si not compressed. Not gzip format sitemap.xml.gz not is not compressed. Not gzip format Mar 29, 2023
@tiberiuichim
Copy link
Contributor

volto/src/helpers/Sitemap/Sitemap.js

Lines 47 to 49 in 33962f1

zlib.gzip(Buffer.from(result, 'utf8'), (_err, buffer) => {
resolve(buffer);
});

@avoinea
Copy link
Member Author

avoinea commented Mar 29, 2023

Yes. Stil I can't figure out why the output is text/xml instead of gzip.

@dobri1408 dobri1408 self-assigned this Apr 5, 2023
@dobri1408 dobri1408 mentioned this issue Apr 6, 2023
Closed
@avoinea avoinea changed the title sitemap.xml.gz not is not compressed. Not gzip format sitemap.xml.gz is not compressed. Not gzip format Apr 6, 2023
sneridagh pushed a commit that referenced this issue Apr 11, 2023
@dobri1408 @avoinea
fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
2adb993 
Co-authored-by: Alin Voinea <contact@avoinea.com>
sneridagh pushed a commit that referenced this issue Apr 11, 2023
@dobri1408 @avoinea @sneridagh
fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
a30d905 
Co-authored-by: Alin Voinea <contact@avoinea.com>
sneridagh added a commit that referenced this issue Apr 11, 2023
@sneridagh @dobri1408 @avoinea
fix sitemap.xml.gz is not compressed #4622 (v2) (#4663) (#4678)
0b04ce4 
Co-authored-by: dobri1408 <50819975+dobri1408@users.noreply.github.com>
Co-authored-by: Alin Voinea <contact@avoinea.com>
@avoinea
Copy link
Member Author

avoinea commented Apr 11, 2023

Fixed by #4663 #4678

@avoinea avoinea closed this as completed Apr 11, 2023
sneridagh added a commit that referenced this issue Apr 17, 2023
@sneridagh
Merge branch 'master' into typescript-support-in-core
a36e7ff 
* master: (22 commits)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694)
  Fix Move to top of folder ordering in folder content view (#4691)
  Changelog
  Revert "Add current page parameter to the route in the listing and search block pagination (#4159)" (#4695)
  Release generate-volto 7.0.0-alpha.4
  Force the resolution of the `react-error-overlay` package to `6.0.9` (#4687)
  Fix training links (#4635)
  Release 17.0.0-alpha.4
  Release changelog notes for 16.20.0 (#4684)
  Update to latest backend versions (#4682)
  Support RelationList field with StaticCatalogVocabulary and SelectWidget. (#4614)
  Load a theme via a `theme` key in `volto.config.js` or in `package.json` (#4625)
  docs: improve creating view documentation (#4636)
  fix sitemap.xml.gz is not compressed #4622 (v2) (#4663)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dobri1408 dobri1408

Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix sitemap.xml.gz not is not compressed #4622 plone/volto
3 participants
@tiberiuichim @avoinea @dobri1408