Closes issue #4567 #4570
Merged
Closes issue #4567 #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #4638 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
stevepiercy
previously requested changes
Mar 18, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com>
STOP!Why are you editing all these random files that have nothing to do with the issue that you are trying to fix? |
|
Sorry @stevepiercy for changing such files. But the errors in the checks suggested so I did that. I think that my local repository was outdated than the branch, that is why this happened. Now I have reverted all those changes |
|
Correct. Keep in mind that Volto is under continual, rapid development. That means you must frequently merge Next step is for a maintainer to review your PR. Tip: check git blame for the file's history to see who edited it in the past. |
|
@sneridagh can you review the PR |
sneridagh
approved these changes
May 6, 2023
sneridagh
added a commit
that referenced
this pull request
May 10, 2023
* master: (83 commits) Apply suggestion from browser for password field (#4524) (fix):Object.normaliseMail: Cannot read properties of null (#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (#4742) added documentation regarding the static middleware #4518 (#4736) Closes issue #4567 (#4570) Fix whitespace in locales created by the generator (#4737) Tidy up from synch with 16.x.x (#4728) Release notes from 16.20.2, 16.20.3, 16.20.4 (#4729) Use new URL 6.docs.plone.org (#4726) Security upgrade for momentjs (#4715) Don't decode querystring while adding apiExpanders (#4719) (Synchronize redundant block id in listing block on pasting) Fix duplicating listing block (#4239) Translate add-on control panel (cleaned up PR) (#4620) Fix Move to top of folder ordering in folder content view by searchin… (#4709) Fix robot.txt - the sitemap link should respect x-forwarded headers (#4704) Refactor faulty reorder elements in ObjectBrowserList widget (#4703) Release changelog notes for 16.20.1 Release 17.0.0-alpha.5 Generate a split sitemap (also fix robots.txt) (#4639) Fix search block in edit mode re-queries multiple blocks with an empty search text (#4694) ...
sneridagh
added a commit
that referenced
this pull request
May 11, 2023
* master: (185 commits) fix: unresponsive add page (#4507) Apply suggestion from browser for password field (#4524) (fix):Object.normaliseMail: Cannot read properties of null (#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (#4742) added documentation regarding the static middleware #4518 (#4736) Closes issue #4567 (#4570) Fix whitespace in locales created by the generator (#4737) Tidy up from synch with 16.x.x (#4728) Release notes from 16.20.2, 16.20.3, 16.20.4 (#4729) Use new URL 6.docs.plone.org (#4726) Security upgrade for momentjs (#4715) Don't decode querystring while adding apiExpanders (#4719) (Synchronize redundant block id in listing block on pasting) Fix duplicating listing block (#4239) Translate add-on control panel (cleaned up PR) (#4620) Fix Move to top of folder ordering in folder content view by searchin… (#4709) Fix robot.txt - the sitemap link should respect x-forwarded headers (#4704) Refactor faulty reorder elements in ObjectBrowserList widget (#4703) Release changelog notes for 16.20.1 Release 17.0.0-alpha.5 Generate a split sitemap (also fix robots.txt) (#4639) ...
sneridagh
added a commit
to ninanoleto/volto
that referenced
this pull request
May 20, 2023
* master: (29 commits) Remove max_line_length from .editorconfig (plone#4776) Fix bug showing logs at the browsers when richtext widget is use (plone#4780) Show expired and future content in contents view (plone#4764) Fix reducing expanders loaded in a subrequest (plone#4761) Update release notes for 16.20.5 and 16.20.6 (plone#4759) Release 17.0.0-alpha.7 Try to sort out volto's use of language codes (plone#4741) Improve .npmignore to not include not needed files/folders (plone#4746) Release 17.0.0-alpha.6 Control panel list SSR (plone#3749) Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178) Upgrade to Plone 6.0.4 (plone#4743) fix: unresponsive add page (plone#4507) Apply suggestion from browser for password field (plone#4524) (fix):Object.normaliseMail: Cannot read properties of null (plone#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742) added documentation regarding the static middleware plone#4518 (plone#4736) Closes issue plone#4567 (plone#4570) Fix whitespace in locales created by the generator (plone#4737) Tidy up from synch with 16.x.x (plone#4728) ...
sneridagh
added a commit
that referenced
this pull request
May 20, 2023
* master: (29 commits) Remove max_line_length from .editorconfig (#4776) Fix bug showing logs at the browsers when richtext widget is use (#4780) Show expired and future content in contents view (#4764) Fix reducing expanders loaded in a subrequest (#4761) Update release notes for 16.20.5 and 16.20.6 (#4759) Release 17.0.0-alpha.7 Try to sort out volto's use of language codes (#4741) Improve .npmignore to not include not needed files/folders (#4746) Release 17.0.0-alpha.6 Control panel list SSR (#3749) Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (#4178) Upgrade to Plone 6.0.4 (#4743) fix: unresponsive add page (#4507) Apply suggestion from browser for password field (#4524) (fix):Object.normaliseMail: Cannot read properties of null (#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (#4742) added documentation regarding the static middleware #4518 (#4736) Closes issue #4567 (#4570) Fix whitespace in locales created by the generator (#4737) Tidy up from synch with 16.x.x (#4728) ...
sneridagh
added a commit
to ninanoleto/volto
that referenced
this pull request
May 20, 2023
* typescript-support-in-core: (29 commits) Remove max_line_length from .editorconfig (plone#4776) Fix bug showing logs at the browsers when richtext widget is use (plone#4780) Show expired and future content in contents view (plone#4764) Fix reducing expanders loaded in a subrequest (plone#4761) Update release notes for 16.20.5 and 16.20.6 (plone#4759) Release 17.0.0-alpha.7 Try to sort out volto's use of language codes (plone#4741) Improve .npmignore to not include not needed files/folders (plone#4746) Release 17.0.0-alpha.6 Control panel list SSR (plone#3749) Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178) Upgrade to Plone 6.0.4 (plone#4743) fix: unresponsive add page (plone#4507) Apply suggestion from browser for password field (plone#4524) (fix):Object.normaliseMail: Cannot read properties of null (plone#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742) added documentation regarding the static middleware plone#4518 (plone#4736) Closes issue plone#4567 (plone#4570) Fix whitespace in locales created by the generator (plone#4737) Tidy up from synch with 16.x.x (plone#4728) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlns={name?.attributes?.xmlns}viewBox={name?.attributes?.viewBox}Added optional chaining in Icon.jsx
Closing issue #4567