Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unresponsive add page #4507

Merged
merged 5 commits into from
May 10, 2023
Merged

fix: unresponsive add page #4507

merged 5 commits into from
May 10, 2023

Conversation

sudhanshu1309
Copy link
Contributor

The tabs for the add page was unresponsive on mobile devices. Fixed this by changing flex-wrap property
closes #4506

@sudhanshu1309
fix: unresponsive add page
7dea90c 
The tabs  for the add page was unresponsive on mobile devices. Fixed this by changing flex-wrap property
@sudhanshu1309 sudhanshu1309 self-assigned this Mar 12, 2023
@netlify
Copy link

netlify bot commented Mar 12, 2023 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 689454b
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/645ba5db5072f80008d88c5f

stevepiercy
stevepiercy requested changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub likes a final line break as an EOF indicator, else it shows a red circle with a slash through it.

Also delete extra space.

theme/themes/pastanaga/extras/sidebar.less Outdated Show resolved Hide resolved
stevepiercy
stevepiercy requested changes Mar 14, 2023
View reviewed changes
news/4506.bugfix Outdated Show resolved Hide resolved
@sudhanshu1309 @stevepiercy
Update news/4506.bugfix
69a8169 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy
Copy link
Collaborator

This needs review by a core Volto developer before merging.

sneridagh
sneridagh approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is good to go.

@sneridagh sneridagh merged commit e724aac into plone:master May 10, 2023
sneridagh added a commit that referenced this pull request May 11, 2023
@sneridagh
Merge branch 'master' into sort-controlpanel-by-title
a20dd5a 
* master: (185 commits)
  fix: unresponsive add page (#4507)
  Apply suggestion from browser for password field (#4524)
  (fix):Object.normaliseMail: Cannot read properties of null (#4558)
  Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (#4742)
  added documentation regarding the static middleware #4518 (#4736)
  Closes issue #4567 (#4570)
  Fix whitespace in locales created by the generator (#4737)
  Tidy up from synch with 16.x.x (#4728)
  Release notes from 16.20.2, 16.20.3, 16.20.4 (#4729)
  Use new URL 6.docs.plone.org (#4726)
  Security upgrade for momentjs (#4715)
  Don't decode querystring while adding apiExpanders (#4719)
  (Synchronize redundant block id in listing block on pasting) Fix duplicating listing block (#4239)
  Translate add-on control panel (cleaned up PR) (#4620)
  Fix Move to top of folder ordering in folder content view by searchin… (#4709)
  Fix robot.txt - the sitemap link should respect x-forwarded headers (#4704)
  Refactor faulty reorder elements in ObjectBrowserList widget (#4703)
  Release changelog notes for 16.20.1
  Release 17.0.0-alpha.5
  Generate a split sitemap (also fix robots.txt) (#4639)
  ...
sneridagh added a commit that referenced this pull request May 12, 2023
@sudhanshu1309 @stevepiercy @sneridagh
fix: unresponsive add page (#4507)
929250d 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh added a commit that referenced this pull request May 12, 2023
@sneridagh @sudhanshu1309 @stevepiercy
fix: unresponsive add page (#4507) (#4753)
d496269 
Co-authored-by: Sudhanshu Tripathi <sudhanshutripathi008@gmail.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit to ninanoleto/volto that referenced this pull request May 20, 2023
@sneridagh
Merge branch 'master' into typescript-fix-jest
a14b67f 
* master: (29 commits)
  Remove max_line_length from .editorconfig (plone#4776)
  Fix bug showing logs at the browsers when richtext widget is use (plone#4780)
  Show expired and future content in contents view (plone#4764)
  Fix reducing expanders loaded in a subrequest (plone#4761)
  Update release notes for 16.20.5 and 16.20.6 (plone#4759)
  Release 17.0.0-alpha.7
  Try to sort out volto's use of language codes (plone#4741)
  Improve .npmignore to not include not needed files/folders (plone#4746)
  Release 17.0.0-alpha.6
  Control panel list SSR (plone#3749)
  Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178)
  Upgrade to Plone 6.0.4 (plone#4743)
  fix: unresponsive add page (plone#4507)
  Apply suggestion from browser for password field (plone#4524)
  (fix):Object.normaliseMail: Cannot read properties of null (plone#4558)
  Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742)
  added documentation regarding the static middleware plone#4518 (plone#4736)
  Closes issue plone#4567 (plone#4570)
  Fix whitespace in locales created by the generator (plone#4737)
  Tidy up from synch with 16.x.x (plone#4728)
  ...
sneridagh added a commit that referenced this pull request May 20, 2023
@sneridagh
Merge branch 'master' into typescript-support-in-core
d9efcea 
* master: (29 commits)
  Remove max_line_length from .editorconfig (#4776)
  Fix bug showing logs at the browsers when richtext widget is use (#4780)
  Show expired and future content in contents view (#4764)
  Fix reducing expanders loaded in a subrequest (#4761)
  Update release notes for 16.20.5 and 16.20.6 (#4759)
  Release 17.0.0-alpha.7
  Try to sort out volto's use of language codes (#4741)
  Improve .npmignore to not include not needed files/folders (#4746)
  Release 17.0.0-alpha.6
  Control panel list SSR (#3749)
  Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (#4178)
  Upgrade to Plone 6.0.4 (#4743)
  fix: unresponsive add page (#4507)
  Apply suggestion from browser for password field (#4524)
  (fix):Object.normaliseMail: Cannot read properties of null (#4558)
  Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (#4742)
  added documentation regarding the static middleware #4518 (#4736)
  Closes issue #4567 (#4570)
  Fix whitespace in locales created by the generator (#4737)
  Tidy up from synch with 16.x.x (#4728)
  ...
sneridagh added a commit to ninanoleto/volto that referenced this pull request May 20, 2023
@sneridagh
Merge branch 'typescript-support-in-core' into typescript-fix-jest
65dceaf 
* typescript-support-in-core: (29 commits)
  Remove max_line_length from .editorconfig (plone#4776)
  Fix bug showing logs at the browsers when richtext widget is use (plone#4780)
  Show expired and future content in contents view (plone#4764)
  Fix reducing expanders loaded in a subrequest (plone#4761)
  Update release notes for 16.20.5 and 16.20.6 (plone#4759)
  Release 17.0.0-alpha.7
  Try to sort out volto's use of language codes (plone#4741)
  Improve .npmignore to not include not needed files/folders (plone#4746)
  Release 17.0.0-alpha.6
  Control panel list SSR (plone#3749)
  Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178)
  Upgrade to Plone 6.0.4 (plone#4743)
  fix: unresponsive add page (plone#4507)
  Apply suggestion from browser for password field (plone#4524)
  (fix):Object.normaliseMail: Cannot read properties of null (plone#4558)
  Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742)
  added documentation regarding the static middleware plone#4518 (plone#4736)
  Closes issue plone#4567 (plone#4570)
  Fix whitespace in locales created by the generator (plone#4737)
  Tidy up from synch with 16.x.x (plone#4728)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneridagh sneridagh sneridagh approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

@iFlameing iFlameing Awaiting requested review from iFlameing

Assignees

@sudhanshu1309 sudhanshu1309

Labels
GSOC-input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unresponsive Add Page for the File, Image and Link
3 participants
@sudhanshu1309 @stevepiercy @sneridagh