Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ily open any number of them.
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5097 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
@plone/volto-team okay, could be that some Cypress tests break... I'd be ok if we decide it to mark it as breaking and go for 17. |
tiberiuichim
approved these changes
Dec 23, 2022
|
Volto Team decission:
|
… the component, so we can reuse them
sneridagh
added a commit
to ninanoleto/volto
that referenced
this pull request
May 20, 2023
* master: (29 commits) Remove max_line_length from .editorconfig (plone#4776) Fix bug showing logs at the browsers when richtext widget is use (plone#4780) Show expired and future content in contents view (plone#4764) Fix reducing expanders loaded in a subrequest (plone#4761) Update release notes for 16.20.5 and 16.20.6 (plone#4759) Release 17.0.0-alpha.7 Try to sort out volto's use of language codes (plone#4741) Improve .npmignore to not include not needed files/folders (plone#4746) Release 17.0.0-alpha.6 Control panel list SSR (plone#3749) Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178) Upgrade to Plone 6.0.4 (plone#4743) fix: unresponsive add page (plone#4507) Apply suggestion from browser for password field (plone#4524) (fix):Object.normaliseMail: Cannot read properties of null (plone#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742) added documentation regarding the static middleware plone#4518 (plone#4736) Closes issue plone#4567 (plone#4570) Fix whitespace in locales created by the generator (plone#4737) Tidy up from synch with 16.x.x (plone#4728) ...
sneridagh
added a commit
that referenced
this pull request
May 20, 2023
* master: (29 commits) Remove max_line_length from .editorconfig (#4776) Fix bug showing logs at the browsers when richtext widget is use (#4780) Show expired and future content in contents view (#4764) Fix reducing expanders loaded in a subrequest (#4761) Update release notes for 16.20.5 and 16.20.6 (#4759) Release 17.0.0-alpha.7 Try to sort out volto's use of language codes (#4741) Improve .npmignore to not include not needed files/folders (#4746) Release 17.0.0-alpha.6 Control panel list SSR (#3749) Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (#4178) Upgrade to Plone 6.0.4 (#4743) fix: unresponsive add page (#4507) Apply suggestion from browser for password field (#4524) (fix):Object.normaliseMail: Cannot read properties of null (#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (#4742) added documentation regarding the static middleware #4518 (#4736) Closes issue #4567 (#4570) Fix whitespace in locales created by the generator (#4737) Tidy up from synch with 16.x.x (#4728) ...
sneridagh
added a commit
to ninanoleto/volto
that referenced
this pull request
May 20, 2023
* typescript-support-in-core: (29 commits) Remove max_line_length from .editorconfig (plone#4776) Fix bug showing logs at the browsers when richtext widget is use (plone#4780) Show expired and future content in contents view (plone#4764) Fix reducing expanders loaded in a subrequest (plone#4761) Update release notes for 16.20.5 and 16.20.6 (plone#4759) Release 17.0.0-alpha.7 Try to sort out volto's use of language codes (plone#4741) Improve .npmignore to not include not needed files/folders (plone#4746) Release 17.0.0-alpha.6 Control panel list SSR (plone#3749) Open all accordion'd content in InlineForm by default, allow arbitrarily close any number of them (plone#4178) Upgrade to Plone 6.0.4 (plone#4743) fix: unresponsive add page (plone#4507) Apply suggestion from browser for password field (plone#4524) (fix):Object.normaliseMail: Cannot read properties of null (plone#4558) Fix link in Volto, remove from linkcheck ignore in Documentation v6.0 (plone#4742) added documentation regarding the static middleware plone#4518 (plone#4736) Closes issue plone#4567 (plone#4570) Fix whitespace in locales created by the generator (plone#4737) Tidy up from synch with 16.x.x (plone#4728) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATED 09/03/2023:
Issue: The state (collapsed/open) of the fieldset accordions in the
InlineForm/BlockDataFormis not being preserved.This is a UX problem when the user is editing content and finds out that the state of the settings UI is not the same as he just left before focusing in another block.
Another "problem" is that the accordions start closed by default. This could be problematic because to my experience some users oversee that the fieldset could be "opened" when they first access the block settings.
I quote "problem" because could be that someone could prefer it to be otherwise.
This PR is fixing both issues by using
jotailibrary to save the state for each block. We are adding a new library here, but I think given the power that it provides, it's worth to test it. It only adds 2k (!) to the build.This is a breaking change, but we have the ability to put it under a configuration setting to control the default behavior, then we could backport it to 16.
I leave the Volto Team meeting the final decision.