-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize data in form before the checks for the blocks
and blocks_layout
are done
#5445
Conversation
…ould be set before the checks
✅ Deploy Preview for volto canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea how to reproduce the bug for testing, but it looks reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it, as we're baking in default empty form in that initial data, so it's no longer the same as the data that comes from the server. But this has me thinking: it's a smell of something rotten somewhere else. How about we don't initialize an empty form if the server is still pending data?
The edge case: A content type created programatically, having Agreed that this should happen in the server probably if the data exists and it's wrong. |
* main: Move dangling news item to the right place Better start script in root package.json, enable and better config for husky/lint-staged All in with monorepo (#5409) changed toNumber to parseFloat #5447 (#5448) Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449)
* main: Cleanup and renaming (#5456)
…s_layout` are done (plone#5445)
This fix an edge case when the data from the server content is empty, then the fields are populated, but the initialized data is snapshot after the check (and amendments) are done.