All in with monorepo #5409

sneridagh · 2023-11-16T20:02:19Z

Note for Volto core developers (/cc @plone/volto-team)

Once this is merged, please take a look at: https://github.com/plone/volto/blob/a5401295af0a4fb799401102788ab446f4ad6276/docs/source/contributing/developing-core.md

It is recommended that you remove your node_modules from your local Volto cloned repository, then run pnpm i. You cannot run the repo with other thing than pnpm anymore.

If you have any PR opened these days, you'll have to update it using the command line. git is able to detect the moves, but you probably will have to confirm them. Also, the Volto news items now live in packages/volto/news but git is also detecting them.

We will be improving and polishing in the next days in case that there's something still not adjusted.

netlify · 2023-11-16T20:02:24Z

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	`f836425`
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/65659dcb4565860008e78f3f

* main: Updated Readme.md (#5401) Transfer of main Plone types definitions to its own package (#5397) Fix reference link to configuration/settings (#5410) Docs: remove orphans and move branch, version, and support policies i… (#5385) Add documentation chapter to Volto contributing (#5377) Release generate-volto 8.0.2 Add postcss-less to the default addon (#5408)

tiberiuichim · 2023-11-17T17:16:33Z

.vscode/settings.json

@@ -0,0 +1,23 @@
+{


Is this file intended to be here? I see some customizations, which may not be to everyone's liking.

The colors? :) It is required for the eslint config to get it right. Don't know if that config can be "global". I will remove the colors.

FYI, The colors are only "the shell" of VScode customizations though, using the Peacock official extension.

Removed! no longer needed.

* main: Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420) Fix image paths in development mode (#5429)

sneridagh · 2023-11-24T20:59:53Z

@plone/volto-team I think this is ready.

All is green, except the Towncrier checks will fail because it does not have "reference" with main. Once it's merged, it will be fine. I'd like to merge as soon as possible because it's already a mess to look at the changes, since it detects more than 3000 and Github file diff view just dies. We can refine in subsequents PRs.

I've tested to merge PRs and all file movements are detected well. So existing PRs will behave correctly (the merge has to be done via command line, locally). We'll have to see how difficult the backports to 16 are. We could also move 16 build to a monorepo approach, shouldn't be that hard, and pretty straightforward following the changes in main.

davisagli

@sneridagh When I switched to this branch to take a look, I got an error from pnpm:

% git checkout gotomonorepo                                                                                                                                                                                                          
branch 'gotomonorepo' set up to track 'origin/gotomonorepo' by rebasing.
Switched to a new branch 'gotomonorepo'
Changes to lockfile found, running `pnpm install`
 ERROR  Unknown option: 'prefer-frozen-shrinkwrap'
Did you mean 'prefer-frozen-lockfile'? Use "--config.unknown=value" to force an unknown option.
For help, run: pnpm help install
Running pnpm pnpm install,--prefer-offline,--prefer-frozen-shrinkwrap,--no-optional failed

.github/workflows/acceptance.yml

README.md

SECURITY.md

TODO-Monorepo.md

davisagli · 2023-11-27T02:16:52Z

apps/plone/package.json

What is the purpose of adding apps/plone to the repository?

It's part of the reorganization, as you already read in the docs, the idea of the apps folder is having all the support apps in there as in docs, api.

The other idea is a playground with demostration of frameworks using the libraries, ideally having them tested too in CI.

If so, having a Volto project in there, and being able to test it in full seems "natural" to have it too. Also to test new things in there, like in the near future pnpm for projects too, or play with the idea of having a more "light" project setup for Volto as a library, without relying on Razzle, something I discussed so many times with @tiberiuichim
This will allow also a better CI story on Volto projects too.

I mentioned this in a private conversation -- I think we'll need to follow up soon with some checks to make sure apps/plone doesn't fall out of sync with the project generator.

davisagli · 2023-11-27T02:18:30Z

packages/generator-volto/generators/app/index.js

@@ -123,7 +121,7 @@ Run "npm install -g @plone/generator-volto" to update.`,

    if (!this.voltoYarnLock) {
      this.log(chalk.red("Retrieving Volto's yarn.lock"));
-      this.voltoYarnLock = await utils.getVoltoYarnLock(voltoVersion);
+      // this.voltoYarnLock = await utils.getVoltoYarnLock(voltoVersion);


Does the generator still need some work? We shouldn't be logging that it is retrieving yarn.lock if that's not what it is doing.

True, I forgot about this one. My gut feeling is it should be removed, we force every time to create a new lock file on the project. It's not necessarily wrong, as long as in CI we test it. Although we could think in adding more tests to ensure that all is in place (eg. linting and prettifying) and we don't have hoisting problems (the fact that it does start and tests pass it's more than enough, but not complete from the DX point of view).

What do you think?

I agree, the important thing is that it works and that we have tests to make sure it keeps working.

sneridagh · 2023-11-27T08:25:29Z

@sneridagh When I switched to this branch to take a look, I got an error from pnpm:

Updated yarnhook to latest allows full support to pnpm: #5444

* main: Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444) Special breadcrumb in controlpanel (#5292) Adding extraction of videoID from youtube videos url which contain '/live/' (#5426) Release 18.0.0-alpha.2 Release generate-volto 8.0.3 Changelog Bring back yeoman install which in v5 is deprecated (#5438) Improvements and completeness of the ContentMetadataTags component (#5433)

* main: Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449)

* main: changed toNumber to parseFloat #5447 (#5448)

* main: Move dangling news item to the right place Better start script in root package.json, enable and better config for husky/lint-staged All in with monorepo (#5409) changed toNumber to parseFloat #5447 (#5448) Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449) Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444) Special breadcrumb in controlpanel (#5292) Adding extraction of videoID from youtube videos url which contain '/live/' (#5426) Release 18.0.0-alpha.2 Release generate-volto 8.0.3 Changelog Bring back yeoman install which in v5 is deprecated (#5438) Improvements and completeness of the ContentMetadataTags component (#5433) Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420) Fix image paths in development mode (#5429) Visible focus semantic UI - reset (#5335) Remove mention of LTS in Volto (#4905) JSX is now in Pygments (#5412)

* main: Move dangling news item to the right place Better start script in root package.json, enable and better config for husky/lint-staged All in with monorepo (#5409) changed toNumber to parseFloat #5447 (#5448) Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449)

* main: (21 commits) Cleanup and renaming (#5456) Move dangling news item to the right place Better start script in root package.json, enable and better config for husky/lint-staged All in with monorepo (#5409) changed toNumber to parseFloat #5447 (#5448) Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449) Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444) Special breadcrumb in controlpanel (#5292) Adding extraction of videoID from youtube videos url which contain '/live/' (#5426) Release 18.0.0-alpha.2 Release generate-volto 8.0.3 Changelog Bring back yeoman install which in v5 is deprecated (#5438) Improvements and completeness of the ContentMetadataTags component (#5433) Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420) Fix image paths in development mode (#5429) Visible focus semantic UI - reset (#5335) Remove mention of LTS in Volto (#4905) ...

Co-authored-by: Steve Piercy <web@stevepiercy.com>

sneridagh added 4 commits November 16, 2023 13:18

WIP

dbf2d87

Remove all traces of yarn

8d80b04

Add pnpm

91bb0c2

Vanila Volto working

d346be7

sneridagh requested a review from tiberiuichim November 16, 2023 20:02

sneridagh added 9 commits November 16, 2023 22:06

The project works now :) 😎

45512e2

include types

c82d2a0

typos

4368f6a

Fix vscode ESlint

3aaacec

Fix code analysis

419bd51

Improve pnpm instll

cae0066

add prettier entry

9f53cba

Unified Prettier config

c1767fb

tiberiuichim reviewed Nov 17, 2023

View reviewed changes

sneridagh added 14 commits November 17, 2023 22:10

Fix code and unit and try acceptance

a3ab67a

Prettier external files

d55226d

Fix i18n

d870224

Fix acceptance test

dbff7c6

Remove yarn

22df10b

Razzle does not like baseURL different than src...

c4767a5

Add wait-on

7f8971b

debug

4f8b86a

debug2

3ff3222

debug3

3ae8400

debug4

b7923bb

debug5

3d3b252

Fix build

07477ee

REmove cache

b6d1482

sneridagh marked this pull request as ready for review November 24, 2023 16:57

Rationalize readmes (#5434)

a540129

sneridagh requested review from davisagli, a team and pnicolli November 24, 2023 20:49

sneridagh added 2 commits November 24, 2023 21:51

Merge branch 'main' into gotomonorepo

2e68a74

* main: Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420) Fix image paths in development mode (#5429)

REmove turborepo README

ae54842

tiberiuichim approved these changes Nov 25, 2023

View reviewed changes

davisagli reviewed Nov 27, 2023

View reviewed changes

sneridagh mentioned this pull request Nov 27, 2023

Update yarnhook to 0.6.1 in order to support pnpm 8 #5444

Merged

sneridagh added 9 commits November 27, 2023 09:31

Match versions in README with the ones tested in Makefile

c4bdf19

Bring back SECURITY and RELEASING to the root of the repo

c568712

Add missing dep from generator-volto

e6651e8

Merge branch 'main' into gotomonorepo

f59abe7

* main: Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449)

Remove outdated TODO file

4df19e7

Remove yarnLock copy traces in generator code

dfa3555

Only allow running with pnpm

807e3a5

Merge branch 'main' into gotomonorepo

f836425

* main: changed toNumber to parseFloat #5447 (#5448)

sneridagh merged commit 81d0369 into main Nov 30, 2023

sneridagh deleted the gotomonorepo branch November 30, 2023 07:35

stevepiercy mentioned this pull request Dec 6, 2023

Add conditional variations support #5424

Merged

sneridagh mentioned this pull request Dec 16, 2023

Adopt a full monorepo approach in the Volto repo #5411

Closed

pranayjoshi pushed a commit to pranayjoshi/volto that referenced this pull request Dec 20, 2023

All in with monorepo (plone#5409)

d984425

Co-authored-by: Steve Piercy <web@stevepiercy.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All in with monorepo #5409

All in with monorepo #5409

sneridagh commented Nov 16, 2023 •

edited

Loading

netlify bot commented Nov 16, 2023 •

edited

Loading

tiberiuichim Nov 17, 2023

sneridagh Nov 17, 2023

sneridagh Nov 17, 2023

sneridagh Nov 30, 2023

sneridagh commented Nov 24, 2023

davisagli left a comment •

edited

Loading

davisagli Nov 27, 2023

sneridagh Nov 27, 2023

davisagli Nov 28, 2023

davisagli Nov 27, 2023

sneridagh Nov 27, 2023 •

edited

Loading

davisagli Nov 28, 2023

sneridagh commented Nov 27, 2023

All in with monorepo #5409

All in with monorepo #5409

Conversation

sneridagh commented Nov 16, 2023 • edited Loading

netlify bot commented Nov 16, 2023 • edited Loading

✅ Deploy Preview for volto canceled.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sneridagh commented Nov 24, 2023

davisagli left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sneridagh Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sneridagh commented Nov 27, 2023

sneridagh commented Nov 16, 2023 •

edited

Loading

netlify bot commented Nov 16, 2023 •

edited

Loading

davisagli left a comment •

edited

Loading

sneridagh Nov 27, 2023 •

edited

Loading