Adding extraction of videoID from youtube videos url which contain '/live/' #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
ericof
requested changes
Nov 24, 2023
|
Sure, I am not familiar with adding tests but I'll look into this. |
… tests for the same and fixing broken thumbnailURLs
|
@ericof I have added the tests could you please go through them once as this my first time writing jest tests so if there is something wrong do let me know. Also I have moved the videoDetails extraction code to a separate function and there was also a issue to video's thumbnails not begin displayed so I also changed the logic to bit to get the correct thumbnail URLs. |
|
The first screenshot is from https://demo.plone.org/ where the videos in which the url contains "list" or ".be" dont have their thumbnails displayed, the second one is from my local server. There was a problem with the extraction of the videoID from the urls with "list" and ".be".
|
ericof
approved these changes
Nov 27, 2023
sneridagh
added a commit
that referenced
this pull request
Nov 27, 2023
* main: Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444) Special breadcrumb in controlpanel (#5292) Adding extraction of videoID from youtube videos url which contain '/live/' (#5426) Release 18.0.0-alpha.2 Release generate-volto 8.0.3 Changelog Bring back yeoman install which in v5 is deprecated (#5438) Improvements and completeness of the ContentMetadataTags component (#5433)
sneridagh
added a commit
that referenced
this pull request
Nov 30, 2023
* main: Move dangling news item to the right place Better start script in root package.json, enable and better config for husky/lint-staged All in with monorepo (#5409) changed toNumber to parseFloat #5447 (#5448) Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449) Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444) Special breadcrumb in controlpanel (#5292) Adding extraction of videoID from youtube videos url which contain '/live/' (#5426) Release 18.0.0-alpha.2 Release generate-volto 8.0.3 Changelog Bring back yeoman install which in v5 is deprecated (#5438) Improvements and completeness of the ContentMetadataTags component (#5433) Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420) Fix image paths in development mode (#5429) Visible focus semantic UI - reset (#5335) Remove mention of LTS in Volto (#4905) JSX is now in Pygments (#5412)
sneridagh
added a commit
that referenced
this pull request
Nov 30, 2023
* main: (21 commits) Cleanup and renaming (#5456) Move dangling news item to the right place Better start script in root package.json, enable and better config for husky/lint-staged All in with monorepo (#5409) changed toNumber to parseFloat #5447 (#5448) Release 18.0.0-alpha.3 Changelog Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449) Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444) Special breadcrumb in controlpanel (#5292) Adding extraction of videoID from youtube videos url which contain '/live/' (#5426) Release 18.0.0-alpha.2 Release generate-volto 8.0.3 Changelog Bring back yeoman install which in v5 is deprecated (#5438) Improvements and completeness of the ContentMetadataTags component (#5433) Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420) Fix image paths in development mode (#5429) Visible focus semantic UI - reset (#5335) Remove mention of LTS in Volto (#4905) ...
sneridagh
pushed a commit
that referenced
this pull request
Dec 13, 2023
pranayjoshi
pushed a commit
to pranayjoshi/volto
that referenced
this pull request
Dec 20, 2023
sneridagh
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved #5416
Added an extra conditional statement for extracting 'videoID' from youtube video urls containing '/live/'