Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube video embed results to error if video url contains /live/ #5416

Closed
rioksane opened this issue Nov 20, 2023 · 7 comments
Closed

YouTube video embed results to error if video url contains /live/ #5416

rioksane opened this issue Nov 20, 2023 · 7 comments

Comments

@rioksane
Copy link

rioksane commented Nov 20, 2023

YouTube video embed results to error if video url contains /live/

Sorry, something went wrong with your request
t.url.match(...) is null

Tested at https://demo.plone.org

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.youtube.com/watch?v=ISdHvS6Ck3k&list=PLGN9BI-OAQkSXMXVBXLWQAQr0AF2xM_NU&index=19
  2. Click on Share
  3. Copy link https://www.youtube.com/live/ISdHvS6Ck3k?si=COeVakmC1lI6jQy3
  4. Go to Plone 6 Volto site add a new page and add video embed block.
  5. Paste url and save page.

Expected behavior
Video embed should work

Screenshots
Screenshot 2023-11-20 at 19 15 00
Screenshot 2023-11-20 at 19 17 50

Software (please complete the following information):

  • OSX
  • Firefox
  • Volto Version
    plone6-demo 1.0.0
    Volto 17.5.0
    Plone 6.0.8
    plone.restapi 9.1.2
    CMF 3.2
    Zope 5.8.6
    Python 3.11.6 (main, Nov 1 2023, 14:02:22) [GCC 10.2.1 20210110]
    PIL 9.5.0 (Pillow)
@rioksane
Copy link
Author

@ericof this is the video embed issue mentioned

@pranayjoshi
Copy link

pranayjoshi commented Nov 21, 2023

Where is the Video embed option? I can only see the option to add page links etc.

@IshaanDasgupta
Copy link
Contributor

I am working on this

@kuv2707
Copy link

kuv2707 commented Dec 12, 2023

Is the issue resolved?

@stevepiercy
Copy link
Collaborator

@kuv2707 yes it is resolved. @IshaanDasgupta resolved it in the linked PR #5426, but because they did not use the magic GitHub keywords in their description, it was not automatically closed. "Solved" is not a keyword.

@IshaanDasgupta
Copy link
Contributor

Sorry didn't know that. Will do that for future PRs

@stevepiercy
Copy link
Collaborator

@IshaanDasgupta no worries. We're all learning how to improve and use GitHub features here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants