Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong usage of createRef in react function component #5519

Closed
razvanMiu opened this issue Dec 12, 2023 · 3 comments
Closed

Wrong usage of createRef in react function component #5519

razvanMiu opened this issue Dec 12, 2023 · 3 comments
Labels
01 type: bug

Comments

@razvanMiu
Copy link
Contributor

In SidebarPopup component createRef was used in a function component which makes the reference always be null:
https://github.com/plone/volto/blob/16.x.x/src/components/manage/Sidebar/SidebarPopup.jsx#L12

Use useRef instead
@razvanMiu razvanMiu mentioned this issue Dec 12, 2023
Merged
Shibbu264 added a commit to Shibbu264/volto that referenced this issue Dec 12, 2023
@Shibbu264
plone#5519 bugfix
e26fb66
@razvanMiu
Copy link
Contributor Author

razvanMiu commented Dec 12, 2023 •
edited
Loading

@Frs2304 @Shibbu264 I already made a pr with the fix #5520

@plone plone deleted a comment from Frs2304 Dec 12, 2023
@plone plone deleted a comment from Shibbu264 Dec 12, 2023
@plone plone deleted a comment from Frs2304 Dec 12, 2023
@stevepiercy stevepiercy mentioned this issue Dec 12, 2023
Closed
3 tasks
@plone plone deleted a comment from TECH-Wizardz Dec 14, 2023
@siddoinghisjob
Copy link

Is this issue still open? I would like to work on this if it's still open.

@davisagli
Copy link
Member

This was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davisagli @razvanMiu @siddoinghisjob