Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect of https://sustainability.eionet.europa.eu to `https:/… #5941

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix redirect of https://sustainability.eionet.europa.eu to `https:/… #5941

merged 2 commits into from
Apr 2, 2024

Conversation

stevepiercy
Copy link
Collaborator

…/www.eea.europa.eu/en/topics/at-a-glance/sustainability/`.

@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 44fdd60
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/660b4d9afbf5a10008c4c5eb

@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 44fdd60
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/660b4d9ae0a5fb00083e3665

@stevepiercy stevepiercy requested a review from a team April 2, 2024 00:12
@stevepiercy stevepiercy self-assigned this Apr 2, 2024
@stevepiercy stevepiercy mentioned this pull request Apr 2, 2024
Merged
@stevepiercy stevepiercy mentioned this pull request Apr 2, 2024
Merged
@stevepiercy stevepiercy merged commit c990fc8 into main Apr 2, 2024
74 checks passed
@stevepiercy stevepiercy deleted the linkcheck-2024-04-01 branch April 2, 2024 00:22
@ichim-david
Copy link
Member

@stevepiercy the better fix would of been to simply remove the link. There was indeed a separate website but it seems that the content from it was imported within the main eea website and that volto website was shut down.
https://github.com/eea/sustainability-frontend - was set as archive yesterday so indeed it's better not to have this link anymore.
I'll add another pull request later.

@stevepiercy
Copy link
Collaborator Author

@ichim-david thanks for the information. There is a reluctance to remove links from the README, unless they are 404s. I tend to just mindlessly update the 301s. I noticed that there are now three former separate sites that have been Borg-ed up. See https://github.com/search?q=repo%3Aplone%2Fvolto%20www.eea.europa.eu&type=code. Do these three links need to be consolidated into one? We also need to update collective/awesome-volto#20 accordingly.

@ichim-david
Copy link
Member

@ichim-david thanks for the information. There is a reluctance to remove links from the README, unless they are 404s. I tend to just mindlessly update the 301s. I noticed that there are now three former separate sites that have been Borg-ed up. See https://github.com/search?q=repo%3Aplone%2Fvolto%20www.eea.europa.eu&type=code. Do these three links need to be consolidated into one? We also need to update collective/awesome-volto#20 accordingly.

@stevepiercy yeah I understand you had no idea about the status of the links and there was no way for me to give feedback at 1AM when I was sleeping :)
I'll check the collective.awesome and then see about volto core

sneridagh added a commit that referenced this pull request Apr 16, 2024
@sneridagh
Merge branch 'main' into components-header
8da949d 
* main: (28 commits)
  Bump vite from 5.1.5 to 5.1.7 (#5946)
  Fix pt_BR translation of invalid email message (#5953)
  Fix markup shortcuts for bold, italic and strikethough fix (#5606)
  Release 18.0.0-alpha.27
  Release @plone/types 1.0.0-alpha.10
  Improve color widget picker and types (#5948)
  Enhanced navigation reducer in Volto (#5817)
  Release 18.0.0-alpha.26
  Rename news item
  Release @plone/slate 18.0.0-alpha.11
  Release @plone/registry 1.5.5
  Release @plone/types 1.0.0-alpha.9
  docs: Cleanup obsolete EEA projects and update info about EEA main website (#5943)
  Bump vite from 5.1.4 to 5.1.5 (#5942)
  Add a new label `needs: triage` to new bug reports (#5940)
  Fix redirect of `https://sustainability.eionet.europa.eu` to `https:/… (#5941)
  Does not show borders in addon block inputs (#5898)
  Fix edge case in search options mangling when the options are false-ish (#5869)
  Add additional parameters to ContentsUploadModal to be reusable in different scenarios (#5881)
  fix(slate): fix insert/remove element edgecase bug in slate (#5926)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees

@stevepiercy stevepiercy

Labels
None yet
Projects
Release Plone 6 docs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevepiercy @ichim-david @davisagli