fix(slate): fix insert/remove element edgecase bug in slate #5926
Conversation
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
|
@razvanMiu which issue does this PR fix? See Item 2, second bullet point in Create a pull request from your fork. |
| @@ -0,0 +1 @@ | |||
| Fix insert/remove element edgecase bug in slate. @razvanMiu | |||
There was a problem hiding this comment.
What edge case does this fix? Please describe the edge case, and how does what you did fix it.
There was a problem hiding this comment.
I'll make a video demo cuze it's hard to explain
There was a problem hiding this comment.
@stevepiercy I updated the description and the changelog.
|
@razvanMiu at least copy and paste the error stack into the PR, or better yet, create an issue with the error stack after searching the issue tracker for the error message. Someone else might have reported it or is already working on it, which could save you some time and effort. I can write up a description, once you paste the error stack, so I don't have to transcribe the videos. Sometimes the English language can get in the way of doing good work, and if so, if it's easier to write it in your preferred language, we can use a translation service to translate it to English. |
I've created an issue. Hopefully now it's clear. |
|
@razvanMiu thank you! That's an excellent write-up. @plone/volto-team all green and ready for review! |
stevepiercy
dismissed
their stale review
Change log is clearer, issue filed and linked to PR
* main: (28 commits) Bump vite from 5.1.5 to 5.1.7 (#5946) Fix pt_BR translation of invalid email message (#5953) Fix markup shortcuts for bold, italic and strikethough fix (#5606) Release 18.0.0-alpha.27 Release @plone/types 1.0.0-alpha.10 Improve color widget picker and types (#5948) Enhanced navigation reducer in Volto (#5817) Release 18.0.0-alpha.26 Rename news item Release @plone/slate 18.0.0-alpha.11 Release @plone/registry 1.5.5 Release @plone/types 1.0.0-alpha.9 docs: Cleanup obsolete EEA projects and update info about EEA main website (#5943) Bump vite from 5.1.4 to 5.1.5 (#5942) Add a new label `needs: triage` to new bug reports (#5940) Fix redirect of `https://sustainability.eionet.europa.eu` to `https:/… (#5941) Does not show borders in addon block inputs (#5898) Fix edge case in search options mangling when the options are false-ish (#5869) Add additional parameters to ContentsUploadModal to be reusable in different scenarios (#5881) fix(slate): fix insert/remove element edgecase bug in slate (#5926) ...
Closes #5928