Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Drag and Drop #1474

Merged
merged 27 commits into from
May 18, 2020
Merged

Improving Drag and Drop #1474

merged 27 commits into from
May 18, 2020

Conversation

iFlameing
Copy link
Member

Fixes #1446

@sneridagh
Copy link
Member

@iFlameing I've polished it a bit. I will continue this weekend a bit too.

In the meanwhile, can you take a look at the droppable styling?. I've found this:
https://codesandbox.io/embed/github/Utkarshbhimte/beatiful-dnd-custom-placeholder/tree/master/?fontsize=14

https://medium.com/@larryliu_50901/how-to-finally-add-a-custom-placeholder-react-beautiful-dnd-1b1359a94e30

coming from:
atlassian/react-beautiful-dnd#518

Also fixing the tests would be great!

iFlameing and others added 16 commits May 15, 2020 21:38
@iFlameing
adding custom placeholder
3fa3a67
@iFlameing
giving final touch to shadow part
7bf972d
@jackahl @sneridagh
fix error in comment form (#1476)
1e84894 
* fix error on submitting comments

* add container around comment area

* update changelog
@jackahl @sneridagh
add command to set registry settings (#1481)
9782f10 
* add command to set registry settings

* update changelog
@sneridagh @avoinea
Fix for the long lasted issue when creating links in newly created te… (
e64583a 
#1489)

* Fix for the long lasted issue when creating links in newly created text blocks not showing as links until you save.

* Fix tests: Remove focus from component unmount

Co-authored-by: Alin Voinea <contact@avoinea.com>
@sneridagh
Prepare for release
8f363b9
@sneridagh
Release 5.9.1
cb5b73e
@sneridagh
Back to development
ae25e2a
@iFlameing @sneridagh
Refactoring createContent command (#1486)
78b8499 
* refactoring createContent command

* updating changelog.md

* minor fix
@sneridagh
Make available some internal artifacts (Router, Redux Store and Sett… (
5c722bc 
#1473)

* Make available some internal artifacts (Router, Redux Store and Settings) to the Cypress acceptance tests, add docs

* More docs
@sneridagh
Sneak small fixes
60e4c98
@sneridagh
Fix tests
a339cf7
@sneridagh
Fix loosing Draftjseditor-root class in the editor after the inclus…
155912e 
…ion of dnd
@sneridagh
Last touches
8c8f6c3
@sneridagh
Merge branch 'master' into edit
d76cc00 
* master:
  Make available some internal artifacts (Router, Redux Store and Sett… (#1473)
  Refactoring createContent command (#1486)
  Back to development
  Release 5.9.1
  Prepare for release
  Fix for the long lasted issue when creating links in newly created te… (#1489)
  add command to set registry settings (#1481)
  fix error in comment form (#1476)
@sneridagh
Update test
d68d76a
@sneridagh
Copy link
Member

@tiberiuichim @avoinea @pnicolli @nzambello This is a nice one with great UX improvement, however, it does change the wrapper structure in the blocks editor (for good).

I left untouched the internal (existing) class names and structure, hoping that will make the transition easier for existing customizations.

It's my intention to release Volto 6 soon (this weekend), and given the nature of this one, I expect to be able to include it in this release.

What do you think?

pnicolli
pnicolli reviewed May 16, 2020
View reviewed changes
Copy link
Contributor

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to try it, but found a small possible change while reading the code

src/components/manage/Form/Form.jsx Outdated Show resolved Hide resolved
sneridagh and others added 4 commits May 16, 2020 16:27
@sneridagh @pnicolli
Update src/components/manage/Form/Form.jsx
831860c 
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
@sneridagh
Fix prettier
a44cd1e
@sneridagh
Merge branch 'master' into edit
a57563b 
* master:
  Upgrade to Razzle 3.1.1 (#1471)
  Back to development
  Release 5.10.0
  Prepare for release
  Block EditForm to allow editing blocks in sidebar, with schema  (#1480)
  Comment hyperlinks (#1484)
  Fix changelog
  adding cypress test for the comment (#1487)
@sneridagh
Remove md from husky, since we don't really want it there, neither wi…
1b3b5da 
…th the restrictions enforced for js
@sneridagh
Copy link
Member

@pnicolli Tried it out in my current local project and works like a charm :)

I will prepare it to be merged, I will wait until tomorrow, so you all can test it, then merge it and release Volto 6 :)

@nzambello nzambello mentioned this pull request May 18, 2020
Closed
nzambello
nzambello approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@nzambello nzambello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneridagh sneridagh merged commit 51b480c into master May 18, 2020
@sneridagh sneridagh deleted the edit branch May 18, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolli pnicolli pnicolli left review comments

@nzambello nzambello nzambello approved these changes

@avoinea avoinea avoinea approved these changes

@tiberiuichim tiberiuichim Awaiting requested review from tiberiuichim

@tisto tisto Awaiting requested review from tisto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Block drag & drop
6 participants
@iFlameing @sneridagh @avoinea @pnicolli @nzambello @jackahl