Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type info instead of id type as icon title in the folder contents #3456

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

mamico
Copy link
Member

@mamico mamico commented Jul 2, 2022

Use type info instead of id type as icon title in the folder contents.
Type info is for humans and eventually translated.

before:
image

after:
image

@netlify
Copy link

netlify bot commented Jul 2, 2022

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit dcf604e
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/62ce8c0093fee10008896f16

@mamico mamico changed the title type info in folder contents items Use type info instead of id type as icon title in the folder contents Jul 2, 2022
@tiberiuichim
Copy link
Contributor

I think the "Pagina" title would be dependent on the current locale?

@erral
Copy link
Member

erral commented Jul 8, 2022

@tiberiuichim yes that response depends on the backend language, plone.restapi handles the translation of the portal_type and other items in the frontend

@cypress
Copy link

cypress bot commented Jul 13, 2022



Test summary

304 0 15 0


Run details

Project Volto
Status Passed
Commit dcf604e
Started Jul 13, 2022 9:14 AM
Ended Jul 13, 2022 9:26 AM
Duration 12:24 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this works in p.restapi already, or it's due to merge?

@sneridagh
Copy link
Member

Oh yeah, it's brain serialization, merging!

@sneridagh sneridagh merged commit d6317f1 into master Jul 13, 2022
@sneridagh sneridagh deleted the mamico/translate_type_in_foldercontents branch July 13, 2022 10:04
mamico added a commit that referenced this pull request Oct 5, 2022
mamico added a commit to RedTurtle/design-volto-theme that referenced this pull request Oct 5, 2022
Wagner3UB pushed a commit to RedTurtle/design-volto-theme that referenced this pull request Oct 20, 2022
SaraBianchi added a commit to RedTurtle/design-volto-theme that referenced this pull request Oct 26, 2022
* feat: accordion added to modulistica section with +1 item

* fix: accordion implementation

* fix: css transition

* fix: reverted header height change

* chore: release v6.2.2

* fix: overhaul url checking system of Video Block, added tests, added error message in edit (#592)

* fix: overhaul url checking system of Video Block, added tests, added error message in edit

* chore: add changelog in customized components

* fix: review fixes in tests

* feat: added sorting of bandi search results (#593)

* feat: added sorting of bandi search results

* chore: updated locales

* chore: release v6.3.0

* plone/volto#3456 backport

* update yarn.lock

* chore: updated volto-subsites v3.0.4

* chore: release v6.3.1

* chore: updated volto-form-block#v2.8.1

* chore: release v6.3.2

* fix: fixed imports volto-form-block customization

* chore: release v6.3.3

* fix: word-break setted to normal only insite footer-small-prints (#594)

* fix: word-break setted to normal only insite footer-small-prints

* fix: extra selectors removed

* fix: conditional added when itens are bigger then 1

* fix: code adapted to recive the document description

* fix: titleWrapper variable created

* fix: fixed title and description style

Co-authored-by: Sara Bianchi <sara.bianchi@redturtle.it>
Co-authored-by: Piero Nicolli <piero.nicolli@redturtle.it>
Co-authored-by: Martina Bustacchini <41484878+deodorhunter@users.noreply.github.com>
Co-authored-by: Sara Bianchi <43245702+SaraBianchi@users.noreply.github.com>
Co-authored-by: Mauro Amico <mauro.amico@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants