Changed Header into Function based component #4464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
Azzam1503
force-pushed
the
Refactoring-Header-into-functional-Component
branch
from
601c846 to
03182b5
Compare
Azzam1503
force-pushed
the
Refactoring-Header-into-functional-Component
branch
from
24217a8 to
3f28d38
Compare
|
@Azzam1503 Did you carefully read: https://community.plone.org/t/recommendations-for-gsoc-aspirants/16301 ? Please do. We do not expect any work, and won't merge anything from noone, on any project before the grants are published. Please stick to the timings and instructions. |
|
I thought this one was an example for Gsoc. |
|
@Azzam1503 thanks for your contribution, this is going to be addressed as a whole in PLIP: #4460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated
src/components/theme/Header/Header.jsxfrom the class base component to the functional base component.