Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Links #4511

Closed
wants to merge 9 commits into from
Closed

Replace Links #4511

wants to merge 9 commits into from

Conversation

Tishasoumya-02
Copy link
Contributor

@Tishasoumya-02 Tishasoumya-02 commented Mar 14, 2023

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 53f0fe4
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6411fb2dd44e0c000784241b

@sudhanshu1309
Copy link
Contributor

Pull requests must include a towncrier news item. This is a file that is placed in the root of the repository directory at /news.
https://6.docs.plone.org/volto/developer-guidelines/contributing.html#create-a-pull-request

news/#4511.bug Outdated
@@ -0,0 +1 @@
Fix urls from .plone.org/5/volto/ to .plone.org/volto/ @Tishasoumya-02
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix urls from .plone.org/5/volto/ to .plone.org/volto/ @Tishasoumya-02
Fix URLs from `training.plone.org/5/volto/` to `training.plone.org/volto/` @Tishasoumya-02

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this file to 4511.documentation. A bug is more for Volto core functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy
Copy link
Collaborator

Let's wait to see the response from the Volto team regarding @ksuess's question, as we are not certain about the status of the Volto training.

news/4511.documentation Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

Closing as duplicate of #4523

@stevepiercy
Copy link
Collaborator

Apologies @Tishasoumya-02, I did not realize that you and @yahya-cloud were both working on the same issue and duplicating efforts, as I am handling a flood of reviews. To prevent this in the future, it is best practice to:

  • Create an issue to describe the problem
  • Assign yourself to the issue, claiming it
  • Submit a pull request, including the following:
    • Include "Closes #IssueNumber" in a GitHub comment to automatically close the original issue number.
    • Include the issue number in the PR's title for easy reference.
    • Include the issue number being closed in the news item.

I will also try to pay closer attention to what is actually being worked on. Thank you for both of your collaboration and contributions to Plone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants