Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /5/ url and Deleted double import of a component #4512

Closed
wants to merge 9 commits into from

Conversation

yahya-cloud
Copy link
Contributor

@yahya-cloud yahya-cloud commented Mar 14, 2023

Updated the url link from https://training.plone.org/5/ to https://training.plone.org/ from and also deleted double import of single component

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 765e9fc
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6411b88ed45a3d00080a5c5c

@stevepiercy
Copy link
Collaborator

We need to wait to a response to @ksuess's question to determine the status of the Volto training and whether this is the best link to use going forward.

@@ -0,0 +1 @@
Deleted second import and fixed training urls
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give yourself credit!

Suggested change
Deleted second import and fixed training urls
Deleted second import and fixed training URLs. @yahya-cloud

@yahya-cloud
Copy link
Contributor Author

@stevepiercy if I'm correct this training is archived right and it'll be https://training.plone.org/5/ to https://2022.training.plone.org/

@@ -1,6 +1,6 @@
## Documentation

A training on how to create your own website using Volto is available as part of the Plone training at [https://training.plone.org/5/volto/index.html](https://training.plone.org/5/volto/index.html).
A training on how to create your own website using Volto is available as part of the Plone training at [https://training.plone.org/volto/index.html](https://training.plone.org/volto/index.html).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This training will be archived.

Suggested change
A training on how to create your own website using Volto is available as part of the Plone training at [https://training.plone.org/volto/index.html](https://training.plone.org/volto/index.html).
A training on how to create your own website using Volto is available at https://2022.training.plone.org/volto/index.html.

@@ -1,6 +1,6 @@
## Documentation

A training on how to create your own website using Volto is available as part of the Plone training at [https://training.plone.org/5/volto/index.html](https://training.plone.org/5/volto/index.html).
A training on how to create your own website using Volto is available as part of the Plone training at [https://2022.training.plone.org/volto/index.html](https://2022.training.plone.org/volto/index.html).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the last-minute change of plans. We decided that the default Volto training should be the following.

Suggested change
A training on how to create your own website using Volto is available as part of the Plone training at [https://2022.training.plone.org/volto/index.html](https://2022.training.plone.org/volto/index.html).
[Volto Hands-On](https://training.plone.org/voltohandson/index.html) is a training on how to create your own website.

@yahya-cloud
Copy link
Contributor Author

thank you for help, I've made the requested changes can you please check

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were not made. I'm not sure what happened. Perhaps you forgot to push your commits to your fork?

Also I found one more thing to update.

@@ -0,0 +1 @@
Deleted second import and fixed training URLs. @yahya-cloud
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity. Sorry I missed this on my earlier pass.

Suggested change
Deleted second import and fixed training URLs. @yahya-cloud
Deleted duplicate import and fixed training URLs. @yahya-cloud

@yahya-cloud
Copy link
Contributor Author

yes I forgot to push them , I'm really sorry about that, now I've pushed all the requested changes can you please check.

@stevepiercy
Copy link
Collaborator

@yahya-cloud I think that you need to open a PR in the plone/volto repo, instead of from your fork, to run all the required CI builds. This PR cannot be merged until all the GitHub Actions pass.

@yahya-cloud
Copy link
Contributor Author

thank you for your help this far, i have opened the new PR #4523

@davisagli
Copy link
Member

Closing this PR since it was replaced by #4523

@davisagli davisagli closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants