Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video warnings link errors #4578

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Conversation

stevepiercy
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit f410ea7
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/641958c91f3a1e000842a882
😎 Deploy Preview https://deploy-preview-4578--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Mar 20, 2023

Passing run #4582 ↗︎

0 489 20 0 Flakiness 0

Details:

Fix width of videos with a style, as video does not support percentages
Project: Volto Commit: f410ea786a
Status: Passed Duration: 12:47 💡
Started: Mar 21, 2023 7:15 AM Ended: Mar 21, 2023 7:28 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy This doesn't look right; now the videos are only 100 pixels wide.

https://deploy-preview-4578--volto.netlify.app/user-manual/copy-paste-blocks.html

Screenshot 2023-03-20 at 8 58 00 PM

@stevepiercy
Copy link
Collaborator Author

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy oh ok, got it

@stevepiercy stevepiercy self-assigned this Mar 21, 2023
@stevepiercy stevepiercy added this to the Plone 6.0 milestone Mar 21, 2023
@stevepiercy
Copy link
Collaborator Author

@davisagli thanks for the sanity check.

@stevepiercy stevepiercy merged commit 0da6bc8 into master Mar 21, 2023
@stevepiercy stevepiercy deleted the fix-video-warnings-link-errors branch March 21, 2023 07:32
sneridagh pushed a commit that referenced this pull request Mar 21, 2023
sneridagh added a commit that referenced this pull request Mar 21, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit that referenced this pull request Apr 5, 2023
* master: (67 commits)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  Release 17.0.0-alpha.3
  Update changelog relese 16.18.0 (#4596)
  InternalURl helper method should incorporate externalRoutes settings … (#4560)
  Update message Add-on control panel (#4574)
  Fix video warnings link errors (#4578)
  Using Vale in CI for spellcheck (#4423)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants