Normalize list in list; remove empty elements in list items #4583
Conversation
✅ Deploy Preview for volto canceled.
|
…des, so we simplify the fix
Passing run #4678 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
vokoscreenNG-2023-03-22_12-23-34.webmSo the solution is to automatically fix the structure to the desired state in the normalizeNode. |
tiberiuichim
changed the title
tiberiuichim
changed the title
|
@davisagli Somehow the latest slate doesn't play well with cypress. See this PR, with just the lib upgrade, where a lot of tests fail: #4593 This was a solution suggested on the web somewhere. |
| @@ -19,7 +19,7 @@ import { | |||
| export function syncCreateTableBlock(rows) { | |||
| const id = uuid(); | |||
| const block = { | |||
| '@type': 'table', | |||
| '@type': 'slateTable', | |||
There was a problem hiding this comment.
I have no idea why this wasn't flagged before.
| @@ -12,6 +12,16 @@ before(function () { | |||
|
|
|||
| beforeEach(function () { | |||
| cy.log('Setting up API fixture'); | |||
|
|
|||
| // avoid a mysterious test failure with upgrade to slate-react 0.91.4 | |||
| const resizeObserverLoopErrRe = /^[^(ResizeObserver loop limit exceeded)]/; | |||
| "slate": "0.84.0", | ||
| "slate-hyperscript": "0.81.3", | ||
| "slate-react": "0.83.2", | ||
| "slate": "0.91.4", |
There was a problem hiding this comment.
Could this affect existing sites in any way?
There was a problem hiding this comment.
@sneridagh no, I don't think so.
The slate upgrade alone makes our tests fail, I have one PR with only that change. So, regardless of anything, if we want to make the upgrade, we need to do the test fix.
tiberiuichim
changed the title
|
@sneridagh Though let's not rush with this. I'll run more tests, think about it more. If anyone is willing to test this, please do. |
tiberiuichim
changed the title
Fixes #4538