Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows external pr #4621

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/acceptance.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Acceptance Tests
on: [push]
on: [push, pull_request_target]
jobs:
core:
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/code-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Code Analysis Check
on: [push]
on: [push, pull_request_target]

jobs:
prettier:
name: Prettier
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ on:
paths:
- 'docs/**'
# Build pull requests
pull_request:
pull_request_target:
paths:
- 'docs/**'
branches:
- master

jobs:
docs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/towncrier.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Towncrier check
on:
pull_request:
pull_request_target:
types: [assigned, opened, synchronize, reopened, labeled, unlabeled]
branches:
- master
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/unit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Unit Tests
on: [push]
on:
push:
pull_request_target:
branches:
- master
jobs:
unit:
name: Core Unit Tests
Expand Down
29 changes: 26 additions & 3 deletions docs/source/developer-guidelines/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,32 @@ In your report, please specify a few things:
```{include} ./branch-policy.md
```

## Create a pull request
## Sign and send us the Plone Contributors Agreement

You must sign the [Plone Contributor Agreement](https://plone.org/foundation/contributors-agreement) to contribute code and documentation to any Plone project.
This means that we can NOT accept pull requests from you until you do this.
This means that we can NOT accept pull requests from you from any location until you do this.


## First Time Contributors: work from a fork

When we have received and it has been process by a communty member, you will be added to the Plone organisation and added to the Contributors Team on GitHub.
You can create issues, add comments to existing issues, and discuss the development of Plone with others.
Creating branches and editing code on our main repositories is restricted and granted to members who have been active in the Plone community for a while and have shown continued interest to contributing.

- First, verify that your issue is valid by creating it and discussing it with other developers.
- Then, create a fork of the repo in your own workspace, work on your code and make commits.
- When you want to run our code quality checks, create a Pull Request from your repo/branch to the main repository.
- As a security measure, the first run of code Quality checks need to be [approved by a member in our Developers Team](https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)
- A Developer with full access to the workflow will need to review and approve your Pull request.

Please be aware that as long as you are working from a fork, you are the only developer being able to commit to your branch.
Collaboration between developers on bigger pull requests is more efficient when these are done on branch on the main repo.
Therefore: as your first time contribution don't choose a too big problem to solve.
Pick something that you can fix or complete from start to end.



## Documenting your changes

All pull requests must include a `towncrier` news item.
This is a file that is placed in the root of the repository directory at `/news`.
Expand All @@ -57,7 +79,8 @@ strings as translatable as defined in the [i18n guide](../recipes/i18n.md).
## Code Quality

All pull requests must pass tests, documentation builds, and other code quality checks.
Contributors are strongly encouraged to run these checks locally before creating a pull request.
Developers are strongly encouraged to run these checks locally before creating a pull request.
Contributors without full Developer access will need to create a Pull request first and get approval for their first PR from a Developer.
These checks are enforced automatically on every pull request, so you might as well save time and frustration by doing these checks locally first.

Specifically:
Expand Down
1 change: 1 addition & 0 deletions news/4621.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update workflows on the volto repo to support external PR's. [fredvd]