Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue #4660 - shouldn't use a hook like function name for a variable #4693

Merged
merged 8 commits into from
May 23, 2023
Merged

fixed the issue #4660 - shouldn't use a hook like function name for a variable #4693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a699105
fixed the issue #4660 - shouldn't use a hook like function name for …
Kaku-g Apr 13, 2023
daa3530
fixed issue #4660 with required changes
Kaku-g May 10, 2023
2f0b605
Merge branch 'plone:master' into issue4660
Kaku-g May 10, 2023
6772a6d
updated changelog for issue #4660
Kaku-g May 10, 2023
3acef33
Merge branch 'issue4660' of https://github.com/Kaku-g/volto into issu…
Kaku-g May 10, 2023
67f088b
updated changelog for issue #4660
Kaku-g May 10, 2023
ce0b312
Merge branch 'master' into issue4660
sneridagh May 23, 2023
bf5cbd5
Fix changelog
sneridagh May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/4693.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed the issue "shouldn't use a hook like function name for a variable" @Kaku-g
7 changes: 4 additions & 3 deletions packages/volto-slate/src/blocks/Text/SlashMenu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const PersistentSlashMenu = ({ editor }) => {

const [slashMenuSelected, setSlashMenuSelected] = React.useState(0);

const useAllowedBlocks = !isEmpty(allowedBlocks);
const hasAllowedBlocks = !isEmpty(allowedBlocks);
const slashCommand = data.plaintext
?.toLowerCase()
.trim()
Expand All @@ -119,7 +119,7 @@ const PersistentSlashMenu = ({ editor }) => {
const availableBlocks = React.useMemo(
() =>
filter(blocksConfig, (item) =>
useAllowedBlocks
hasAllowedBlocks
? allowedBlocks.includes(item.id)
: typeof item.restricted === 'function'
? !item.restricted({ properties, block: item })
Expand Down Expand Up @@ -150,7 +150,8 @@ const PersistentSlashMenu = ({ editor }) => {
intl,
properties,
slashCommand,
useAllowedBlocks,
hasAllowedBlocks
,
],
);

Expand Down