Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination with router params (#4698) #4908

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

sneridagh
Copy link
Member

@erral please a last look before backporting.

erral and others added 2 commits June 23, 2023 11:48
Co-authored-by: bipoza <bipoza@gmail.com>
Co-authored-by: ionlizarazu <ilizarazu@codesyntax.com>
Co-authored-by: Unai <uetxaburu@codesyntax.eus>
…sync (change not backported initially because the PR containing it was "breaking"
@sneridagh sneridagh added the backport A backport PR to a numbered branch label Jun 23, 2023
@sneridagh sneridagh added this to the 16.x.x milestone Jun 23, 2023
@sneridagh sneridagh requested a review from erral June 23, 2023 09:57
@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit afeaac9
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64956c73eaf9fc0008ebd75f
😎 Deploy Preview https://deploy-preview-4908--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sneridagh sneridagh changed the title Pagination with router params 16 Pagination with router params (#4698) Jun 23, 2023
@erral erral requested review from ionlizarazu and bipoza June 23, 2023 10:00
@cypress
Copy link

cypress bot commented Jun 23, 2023

Passing run #5852 ↗︎

0 469 20 0 Flakiness 0

Details:

Backport changes in `withQuerystringResults.jsx` to maintain both in sync (chang...
Project: Volto Commit: afeaac9c33
Status: Passed Duration: 12:32 💡
Started: Jun 23, 2023 10:00 AM Ended: Jun 23, 2023 10:13 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sneridagh sneridagh merged commit e4c2b24 into 16.x.x Jun 23, 2023
@sneridagh sneridagh deleted the pagination-with-router-params__16 branch June 23, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport A backport PR to a numbered branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants