Add Storybook story for useDetectClickOutside hook with several demos #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
davisagli
approved these changes
Jun 27, 2023
sneridagh
added a commit
that referenced
this pull request
Jun 30, 2023
* master: Add a marker in the props for `RenderBlocks` in case that we have a container (#4932) Update the 'version addded' information regarding the Grid block in docs Release 17.0.0-alpha.16 Grid block in core + primitive Container block (#3180) Release 17.0.0-alpha.15 Fix changelog message and docs for #4848 (#4927) Add Storybook story for useDetectClickOutside hook with several demos (#4923) Fix the experimental add new block button position, compensate the ic… (#4924) Use proper heading tag (depending on the headline) in default listing template (#4848) Fix Annontools storyBook (#4921)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook as it is works well... This is the right way to instantiate it along with popper, and it behaves as expected.
The usage inside the accordion has been fixed (my bad). However the usage in the core grid PR is strange and has nothing to do with the one in the demos... no clue why. It works, but not as expected.