Fix search block input clear button doesn't reset the search (#4837) #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ionlizarazu <ilizarazu@codesyntax.com> Co-authored-by: Mikel Larreategi <mlarreategi@codesyntax.com>
✅ Deploy Preview for volto canceled.
|
Passing run #6610 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
@ionlizarazu @iFlameing there are some problems with the backport of this one. |
|
@sneridagh I've fixed the tests for this branch. The functionality in the master and search-reset-clear__16 branches is different. In master, when you add a search block, all the settings accordions are open, in this branch there are closed by default. |
|
@ionlizarazu thanks a lot for taking care! LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.