-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix preview image #5153
fix preview image #5153
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #7186 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a new test in PreviewImage.test.js for the showDefault=false case. Also some of the existing tests are failing.
updated tests |
* master: fix preview image (#5153) fixed deprecated buffer.from (#5205) feat: add canonical link (#5215) Fix links to link integrity in delete modal (#5226) (fixes #5124) Enhance Accessibility, Add aria-label to search. (#5224) document the querystringSearchGet setting (#5206) Fix empty slate text block in table of contents (#5156)
Fixed PreviewImage component, because it was working only if item.image_scales where setted.
Added show_default prop to display or not default image