Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preview image #5153

Merged
merged 6 commits into from
Sep 26, 2023
Merged

fix preview image #5153

merged 6 commits into from
Sep 26, 2023

Conversation

giuliaghisini
Copy link
Contributor

Fixed PreviewImage component, because it was working only if item.image_scales where setted.
Added show_default prop to display or not default image

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 7bdfd8e
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6512657cfc605b00085b75b5
😎 Deploy Preview https://deploy-preview-5153--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 1, 2023

Passing run #7186 ↗︎

0 561 20 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

chore: upgraded PreviewImage tests
Project: Volto Commit: 2004223c25
Status: Passed Duration: 14:37 💡
Started: Sep 13, 2023 10:26 AM Ended: Sep 13, 2023 10:40 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a new test in PreviewImage.test.js for the showDefault=false case. Also some of the existing tests are failing.

src/components/theme/PreviewImage/PreviewImage.jsx Outdated Show resolved Hide resolved
@giuliaghisini
Copy link
Contributor Author

It would be nice to have a new test in PreviewImage.test.js for the showDefault=false case. Also some of the existing tests are failing.

updated tests

@sneridagh sneridagh merged commit f1610c5 into master Sep 26, 2023
47 checks passed
@sneridagh sneridagh deleted the fix_preview_image branch September 26, 2023 08:48
sneridagh added a commit that referenced this pull request Sep 26, 2023
* master:
  fix preview image (#5153)
  fixed deprecated buffer.from (#5205)
  feat: add canonical link (#5215)
  Fix links to link integrity in delete modal (#5226)
  (fixes #5124) Enhance Accessibility, Add aria-label to search.  (#5224)
  document the querystringSearchGet setting (#5206)
  Fix empty slate text block in table of contents (#5156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants