Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed RenderUser to func comp: #4460 #5178

Closed
wants to merge 3 commits into from
Closed

Changed RenderUser to func comp: #4460 #5178

wants to merge 3 commits into from

Conversation

abhinaisai2002
Copy link

Fix : #4460
Changed src/components/manage/Controlpanels/Users/RenderUsers.jsx to functional component
Lints and Tests are working fine

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit b758ae6
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65014fd8cea9a00008ed0287

@mister-roboto
Copy link

Abhinai Sai your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@mister-roboto
Copy link

@abhinaisai2002 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@mister-roboto
Copy link

Abhinai Sai your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@abhinaisai2002
Copy link
Author

abhinaisai2002 commented Sep 13, 2023

Hey, i have made my email available public to github, and signed the contributor agreement.
@sneridagh can you please help me in this.

@sneridagh
Copy link
Member

sneridagh commented Sep 13, 2023

Hey @abhinaisai2002 thanks for the contribution! however, this matter is being tackled already under the umbrella of not one, but two a GSOC projects, currently in wrapup phase.

I recommend you to ask before tackling an issue, also PLIPs are for seasoned contributors, since they are more advanced features/functionality. You can also ask in the forum and get yourself some background on what's going on in the community.

@stevepiercy
Copy link
Collaborator

@abhinaisai2002 to add to what @sneridagh said, read https://6.docs.plone.org/contributing/first-time.html, which covers how to avoid duplicating efforts in GitHub.

@abhinaisai2002 abhinaisai2002 closed this by deleting the head repository Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor class components to functional components
4 participants