-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed RenderUser to func comp: #4460 #5178
Conversation
✅ Deploy Preview for volto canceled.
|
Abhinai Sai your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account |
@abhinaisai2002 you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
Abhinai Sai your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account |
Hey, i have made my email available public to github, and signed the contributor agreement. |
Hey @abhinaisai2002 thanks for the contribution! however, this matter is being tackled already under the umbrella of not one, but two a GSOC projects, currently in wrapup phase. I recommend you to ask before tackling an issue, also PLIPs are for seasoned contributors, since they are more advanced features/functionality. You can also ask in the forum and get yourself some background on what's going on in the community. |
@abhinaisai2002 to add to what @sneridagh said, read https://6.docs.plone.org/contributing/first-time.html, which covers how to avoid duplicating efforts in GitHub. |
Fix : #4460
Changed src/components/manage/Controlpanels/Users/RenderUsers.jsx to functional component
Lints and Tests are working fine