Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added guard in flattenScales in edge case image is undefined #5318

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Added guard in flattenScales in edge case image is undefined #5318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3daa15
Added guard in `flattenScales` in edge case image is undefined
sneridagh Oct 13, 2023
1ea50f8
Changelog
sneridagh Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/5318.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added guard in `flattenScales` in edge case image is undefined @sneridagh
1 change: 1 addition & 0 deletions src/helpers/Url/Url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ export function flattenScales(path, image) {
function removeObjectIdFromURL(path, scale) {
return scale.replace(`${path}/`, '');
}
if (!image) return;

const imageInfo = {
...image,
Expand Down
6 changes: 6 additions & 0 deletions src/helpers/Url/Url.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,12 @@ describe('Url', () => {
});
});
describe('flattenScales', () => {
it('flattenScales image is not set', () => {
const id = '/halfdome2022-2.jpg';
const image = undefined;
expect(flattenScales(id, image)).toBe(undefined);
});

it('flattenScales test from the catalog', () => {
const id = '/halfdome2022-2.jpg';
const image = {
Expand Down