Attempt to build the components storybook only when its source files …

[stevepiercy]

…change

[netlify]

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	9e46b1e
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/6596a47a7256f50008c467c6

[netlify]

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	9e46b1e
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/6596a47bca705900081b960d

[stevepiercy]

@sneridagh this one is now ready and working, and I reverted its other PR to clean up the change log history. Note that the Netlify build for volto/components gets cancelled when there are no changes to files in its src directory.

[sneridagh]

@stevepiercy it seems that it does not deploy to production (main) since we merged this. Any idea what could be happening? For the PR deploys works well (the filter) but it never deploys in main :(

[stevepiercy]

@sneridagh I'm not clear what you mean. AFAIK, we never deployed the components Storybook to production, only the Volto Storybook. The components Storybook still builds on Netlify at https://plone-components.netlify.app.

[sneridagh]

@stevepiercy sure, "production" Netlify. It never deployed again (last time was March).

[stevepiercy]

OK, last successful "production" build was on Mar 23, 2024.

https://app.netlify.com/sites/plone-components/deploys/65fff4105c8b5800088b8299

This was the last commit to yield a successful build.

8063f11

I don't yet see what changed right after that to prevent a successful build.

[stevepiercy]

I just manually triggered a deploy. Can you check if you see the expected changes?

It should only build on changes in packages/components/src, if I read the config correctly. See:

https://app.netlify.com/sites/plone-components/configuration/deploys#continuous-deployment

I looked back in the history, and ever since Mar 23, 2024, Netlify builds have been cancelled, either because there are no changes in the components storybook or something else I have not yet identified. Can you point me to the first commit after Mar 23, 2024, to main where there are changes to files that should have triggered the deploy? Then we can figure out what went wrong.

[stevepiercy]

I think this should have built, but was cancelled. I don't know why.

https://app.netlify.com/sites/plone-components/deploys/664b27cd9235660008f4ca86

12:37:13 AM: git clone --filter=blob:none https://github.com/plone/volto
12:37:14 AM: Preparing Git Reference refs/heads/main
12:37:16 AM: Custom publish path detected. Proceeding with the specified path: 'packages/components/storybook-static'
12:37:16 AM: Custom ignore command detected. Proceeding with the specified command: 'git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ./src/'
12:37:17 AM: Failed during stage 'checking build content for changes': Canceled build due to no content change
12:37:17 AM: manpath: warning: $PATH not set
12:37:17 AM: User-specified ignore command returned exit code 0. Returning early from build.

[stevepiercy]

I commented out the ignore command and force pushed to main to test.

• 4d0a701
• https://app.netlify.com/sites/plone-components/deploys/670f7ba167e3f0000843be6e

That works. That implies that we probably had the path for doing a diff wrong all along, but were relying on the root ./src of the repo before we switched to the monorepo. In fact that's right about when we switched to monorepo, moving ./src into packages/volto/src/, so there were no more changes to detect.

I'll submit a PR to fix the Netlify ignore command so we can get it in the change log. However we can't test it until we have a change in its src files, even if it is a trivial space or line break.

[stevepiercy]

@sneridagh PR: #6410

[sneridagh]

@stevepiercy thanks!!!