Removed unmaintained and unused razzle-plugin-bundle-analyze #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of directly using webpack-bundle-analyzer
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… code for the given recipe
sneridagh
approved these changes
Jan 26, 2024
sneridagh
added a commit
that referenced
this pull request
Feb 1, 2024
* main: Block search engines from indexing content on Netlify preview builds (#5725) fixed a11y Logo Issue and added Translations (#5722) Allow editor to edit metadata name during bulk or single upload (#5560) 5439 clarify defaultAddonName option and mention to the generator readme the creation of the theme add-on (#5709) Remove turbo from monorepo commands until it's really necessary (#5715) bugfix: wrong conditional proprieties on ObjectBrowser (#4190) Added aria-live='polite' (#5639) Release 18.0.0-alpha.9 Release @plone/scripts 3.3.2 fix: handle addons that have not been migrated to the new structure o… (#5704) Update Semantic UI React to version 2.1.5 (#5632) Removed unmaintained and unused razzle-plugin-bundle-analyze (#5671) 3716 - improve validation of id widget (#4686) Fixed redirect of https://tanstack.com/query/v4/docs/react/guides/ssr… (#5700) Release 18.0.0-alpha.8 Release @plone/volto 18.0.0-alpha.7 (not pushed to main) Release @plone/slate 18.0.0-alpha.6 Release @plone/registry 1.2.1 (not pushed to repo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volto has never used the functionality of this plugin because it uses directly the webpack plugin that we
have in the webpack plugins https://github.com/plone/volto/blob/main/packages/volto/webpack-plugins/webpack-bundle-analyze-plugin.js#L8
https://github.com/plone/volto/blob/main/packages/volto/razzle.config.js#L353
See the readme for the plugin that shows that you need to load bundle-analyzer in the plugins of razzle and we never do
https://www.npmjs.com/package/razzle-plugin-bundle-analyzer#usage-in-razzle-projects
yarn analyze or bundle analyze works without having this unmaintained plugin which forced us in 17.x.x to pin webpack-bundle-analyze-plugin in order to avoid using an old version of it because of the razzle-plugin.