Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade less and semantic ui to latests versions #585

Merged
merged 3 commits into from
Dec 24, 2018
Merged

Upgrade less and semantic ui to latests versions #585

merged 3 commits into from
Dec 24, 2018

Conversation

sneridagh
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2755

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 2746: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@sneridagh sneridagh requested a review from robgietema December 20, 2018 22:34
@sneridagh sneridagh mentioned this pull request Dec 21, 2018
Closed
@sneridagh
Copy link
Member Author

@robgietema approved this PR via slack.
Merging.

@sneridagh sneridagh merged commit c315109 into master Dec 24, 2018
@sneridagh sneridagh deleted the upgrade-less-semantic branch December 24, 2018 12:22
rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/default/collections/menu.variables
@@ -430,7 +430,7 @@
@attachedTopOffset: 0px;
@attachedBottomOffset: 0px;
@attachedHorizontalOffset: -@borderWidth;
@attachedWidth: ~"calc(100% + "-@attachedHorizontalOffset * 2~")";
@attachedWidth: calc(100% - (@attachedHorizontalOffset * 2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/default/collections/table.variables
@@ -152,7 +152,7 @@
@attachedTopOffset: 0px;
@attachedBottomOffset: 0px;
@attachedHorizontalOffset: -@borderWidth;
@attachedWidth: ~"calc(100% + "-@attachedHorizontalOffset * 2~")";
@attachedWidth: calc(100% - (@attachedHorizontalOffset * 2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/collections/menu.variables
@@ -321,7 +321,7 @@
@tabularVerticalBackground: none @tabularBackgroundColor;

@tabularFluidOffset: 1px;
@tabularFluidWidth: ~"calc(100% + "(@tabularFluidOffset * 2)~")";
@tabularFluidWidth: calc(100% + (@tabularFluidOffset * 2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/collections/menu.variables
@@ -430,7 +430,7 @@
@attachedTopOffset: 0px;
@attachedBottomOffset: 0px;
@attachedHorizontalOffset: -@borderWidth;
@attachedWidth: ~"calc(100% + "-@attachedHorizontalOffset * 2~")";
@attachedWidth: calc(100% + -@attachedHorizontalOffset * 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/collections/table.variables
@@ -151,7 +151,7 @@
@attachedTopOffset: 0px;
@attachedBottomOffset: 0px;
@attachedHorizontalOffset: -@borderWidth;
@attachedWidth: ~"calc(100% + "-@attachedHorizontalOffset * 2~")";
@attachedWidth: calc(100% + -@attachedHorizontalOffset * 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/container.overrides
@@ -59,18 +59,18 @@

.drag.handle.wrapper {
@media only screen and (max-width: @largestMobileScreen) {
margin-left: ~'calc(50vw - (' @mobileWidth + ~'/2)) !important';
margin-left: calc(50vw - (@mobileWidth / 2)) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/container.overrides
}

@media only screen and (min-width: @tabletBreakpoint) and (max-width: @largestTabletScreen) {
margin-left: ~'calc(50vw - (' @tabletWidth + ~'/2)) !important';
margin-left: calc(50vw - ( @tabletWidth / 2)) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/container.overrides
}

@media only screen and (min-width: @computerBreakpoint) and (max-width: @largestSmallMonitor) {
margin-left: ~'calc(50vw - (' @computerWidth + ~'/2)) !important';
margin-left: calc(50vw - ( @computerWidth / 2)) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/container.overrides
}

@media only screen and (min-width: @largeMonitorBreakpoint) {
margin-left: ~'calc(50vw - (' @largeMonitorWidth + ~'/2)) !important';
margin-left: calc(50vw - ( @largeMonitorWidth / 2)) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables
@ribbonOffset: ~"calc("-@ribbonMargin~" - "@ribbonTriangleSize~")";
@ribbonDistance: ~"calc("@ribbonMargin~" + "@ribbonTriangleSize~")";
@rightRibbonOffset: ~"calc(100% + "@ribbonMargin~" + "@ribbonTriangleSize~")";
@ribbonOffset: calc(-@ribbonMargin - @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/step.variables
@@ -95,7 +95,7 @@

@attachedHorizontalOffset: -@borderWidth;
@attachedVerticalOffset: 0;
@attachedWidth: ~"calc(100% + "-@attachedHorizontalOffset * 2~")";
@attachedWidth: calc(100% + -@attachedHorizontalOffset * 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables
@ribbonTableOffset: ~"calc("-@ribbonTableMargin~" - "@ribbonTriangleSize~")";
@rightRibbonTableOffset: ~"calc(100% + "@ribbonTableMargin~" + "@ribbonTriangleSize~")";
@ribbonTableOffset: calc(-@ribbonTableMargin - @ribbonTriangleSize);
@rightRibbonTableOffset: calc(100% + @ribbonTableMargin + @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables

@ribbonTableMargin: @relativeMini; /* Rounding Offset on Triangle */
@ribbonTableOffset: ~"calc("-@ribbonTableMargin~" - "@ribbonTriangleSize~")";
@rightRibbonTableOffset: ~"calc(100% + "@ribbonTableMargin~" + "@ribbonTriangleSize~")";
@ribbonTableOffset: calc(-@ribbonTableMargin - @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables
@ribbonImageOffset: ~"calc("-@ribbonImageMargin~" - "@ribbonTriangleSize~")";
@rightRibbonImageOffset: ~"calc(100% + "@ribbonImageMargin~" + "@ribbonTriangleSize~")";
@ribbonImageOffset: calc(-@ribbonImageMargin - @ribbonTriangleSize);
@rightRibbonImageOffset: calc(100% + @ribbonImageMargin + @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables

@ribbonImageTopDistance: 1rem;
@ribbonImageMargin: -0.05rem; /* Rounding Offset on Triangle */
@ribbonImageOffset: ~"calc("-@ribbonImageMargin~" - "@ribbonTriangleSize~")";
@rightRibbonImageOffset: ~"calc(100% + "@ribbonImageMargin~" + "@ribbonTriangleSize~")";
@ribbonImageOffset: calc(-@ribbonImageMargin - @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables
@rightRibbonOffset: ~"calc(100% + "@ribbonMargin~" + "@ribbonTriangleSize~")";
@ribbonOffset: calc(-@ribbonMargin - @ribbonTriangleSize);
@ribbonDistance: calc(@ribbonMargin + @ribbonTriangleSize);
@rightRibbonOffset: calc(100% + @ribbonMargin + @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

rodfersou
rodfersou reviewed Jan 22, 2019
View reviewed changes
theme/themes/pastanaga/elements/label.variables
@ribbonDistance: ~"calc("@ribbonMargin~" + "@ribbonTriangleSize~")";
@rightRibbonOffset: ~"calc(100% + "@ribbonMargin~" + "@ribbonTriangleSize~")";
@ribbonOffset: calc(-@ribbonMargin - @ribbonTriangleSize);
@ribbonDistance: calc(@ribbonMargin + @ribbonTriangleSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should keep the ~" " around less/less.js#974 (comment)

@sneridagh
Copy link
Member Author

@rodfersou The issue is from 2012! I tested it and it works well now, since the latest LESS supports it. In fact, they use bare calc() everywhere now. See

https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/collections/grid.less#L142

and this commits:
Semantic-Org/Semantic-UI@4b4df6c

@sneridagh
Copy link
Member Author

/cc @nileshgulia1 ^^

@rodfersou
Copy link
Member

@sneridagh nice, thank you to point me this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodfersou rodfersou rodfersou left review comments

@robgietema robgietema Awaiting requested review from robgietema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneridagh @coveralls @rodfersou