Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to StoryBook 8 #5912

Merged
merged 13 commits into from
Mar 24, 2024
Merged

Upgrade to StoryBook 8 #5912

merged 13 commits into from
Mar 24, 2024

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 3121d93
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65fff18758043f0008e7ab2d

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 3121d93
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65fff187fcad27000861bb52
😎 Deploy Preview https://deploy-preview-5912--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook is not camelCased.

One suggestion gives you a choice from two options to pick one.

.github/workflows/acceptance.yml Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
packages/components/news/5912.internal Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
packages/generator-volto/news/5912.internal Outdated Show resolved Hide resolved
packages/volto/news/5912.internal Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

Check out the Netlify preview. 🥳

sneridagh and others added 3 commits March 24, 2024 10:23
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@sneridagh
Copy link
Member Author

@stevepiercy yep! looks good!

@sneridagh sneridagh merged commit 8063f11 into main Mar 24, 2024
74 checks passed
@sneridagh sneridagh deleted the storybook8 branch March 24, 2024 09:36
sneridagh added a commit that referenced this pull request Apr 16, 2024
* main: (21 commits)
  Use fieldset `id` instead of the fieldset `title` in Form when rendering the Field component (#5921)
  Fix registry wrong default primitive type (#5925)
  Release @plone/types 1.0.0-alpha.8
  Improve types for APIExpanders, export all (#5918)
  Missing step in storybook migration (#5913)
  Push missing .d.ts files
  Release 18.0.0-alpha.25
  Release generate-volto 9.0.0-alpha.14
  Update Docs: Pastanaga UI and Quanta (#5903)
  Upgrade to StoryBook 8 (#5912)
  Fix Storybook in app gen for Volto 18 (#5911)
  Release 18.0.0-alpha.24
  Upgrade `@typescript-eslint` (#5910)
  Add new cypress helper for slate `getSlateEditorAndType` (#5909)
  Add id attributes to discussions container and individual comments (#5905)
  Move testing-library cypress commands import to inner commands so it can be imported (#5906)
  Release 18.0.0-alpha.23
  Release @plone/registry 1.5.4
  Improve the usage of RAZZLE_JEST_CONFIG (#5901)
  fix reordering of slots function (#5840)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants