-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to StoryBook 8 #5912
Merged
Merged
Upgrade to StoryBook 8 #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tiberiuichim
approved these changes
Mar 24, 2024
stevepiercy
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook is not camelCased.
One suggestion gives you a choice from two options to pick one.
Check out the Netlify preview. 🥳 |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy yep! looks good! |
stevepiercy
approved these changes
Mar 24, 2024
sneridagh
added a commit
that referenced
this pull request
Apr 16, 2024
* main: (21 commits) Use fieldset `id` instead of the fieldset `title` in Form when rendering the Field component (#5921) Fix registry wrong default primitive type (#5925) Release @plone/types 1.0.0-alpha.8 Improve types for APIExpanders, export all (#5918) Missing step in storybook migration (#5913) Push missing .d.ts files Release 18.0.0-alpha.25 Release generate-volto 9.0.0-alpha.14 Update Docs: Pastanaga UI and Quanta (#5903) Upgrade to StoryBook 8 (#5912) Fix Storybook in app gen for Volto 18 (#5911) Release 18.0.0-alpha.24 Upgrade `@typescript-eslint` (#5910) Add new cypress helper for slate `getSlateEditorAndType` (#5909) Add id attributes to discussions container and individual comments (#5905) Move testing-library cypress commands import to inner commands so it can be imported (#5906) Release 18.0.0-alpha.23 Release @plone/registry 1.5.4 Improve the usage of RAZZLE_JEST_CONFIG (#5901) fix reordering of slots function (#5840) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.