Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit login/logout process, better catching of edge cases (unauthor… #6155

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

sneridagh
Copy link
Member

…ized while developing)

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 93ddaf3
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6687b48698e77200080ce3ed

@ichim-david
Copy link
Member

ichim-david commented Jul 5, 2024

@plone/volto-team if you want to test this fix and see the before and after here is a simple testcase that is fixed by this pull request.

  1. Login and create a private document
  2. Logout on that private document
  3. You get unauthorised page with link to login, click it
  4. Login and you will see before that you are not redirected to the page that requested the login you are left on the login page.
    Before you had to click on the logo to go to the homepage and you would see that you were indeed logged in.
    Now as soon as you hit login you are redirected properly.

It's not very obvious what this pull request fixed, it might fix something else but this is the problem I had before and this pull request fixes this issue for me.

@stevepiercy if you want to add something to the docs it's all yours :)

@stevepiercy
Copy link
Collaborator

We have nothing relevant about the logout user experience in the Volto docs: https://6.docs.plone.org/search.html?q=logout&doc_section=volto.

That said, it's yet another reminder that I need to sit down with someone knowledgable to show me how to run Cypress, record screenshots and videos, and store those files in documentation's _static directory. I think the student who was looking into this at the Axolotl Sprint has moved on to other things. It's sad that we have only a minimal user manual for Volto in Plone 6 documentation and none for Classic UI.

@sneridagh
Copy link
Member Author

sneridagh commented Jul 5, 2024

@stevepiercy yeah, it's nowhere to be found. "default" login/logout experience is just "given for granted", and it's not specified anywhere, same for the behavior that:

  • You can login from anywhere content object, then you return to the same point
  • You can logout, you stay in the content object you were located.

I would like having such an asset as a "user guide", we can take a look together at the outcome of what the student left, or maybe plot a plan for moving on from here. Maybe next Volto Team meeting? I think it's important enough to make a plan. Even move it as a PLIP? Let's visibilize it and show that we lack these important documentation part.

Btw, merging this one now, if you don't mind!

@stevepiercy
Copy link
Collaborator

Yes, please merge.

I never saw anything from the student. I'll make a PLIP, as it pertains to both UIs.

@sneridagh sneridagh merged commit c4a98cd into main Jul 5, 2024
70 checks passed
@sneridagh sneridagh deleted the fixloginlogoutprocess-catch-edgecases branch July 5, 2024 13:26
@stevepiercy
Copy link
Collaborator

@sneridagh PLIP done in plone/Products.CMFPlone#3987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants